Skip to content

Commit

Permalink
chore: fix format error and add mac
Browse files Browse the repository at this point in the history
Add macOS.

Odd formatter error on Windows. Minikube skips it, will do the same here.

Add macOS.

Signed-off-by: Tim deBoer <[email protected]>
  • Loading branch information
deboer-tim committed Jan 18, 2024
1 parent e6abff5 commit 02b1c1a
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/pr-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2022, ubuntu-22.04]
os: [windows-2022, ubuntu-22.04, macos-11]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -40,7 +40,7 @@ jobs:
run: echo "dir=$(yarn cache dir)" >> ${env:GITHUB_OUTPUT}

- name: Get yarn cache directory path (mac/Linux)
if: ${{ matrix.os=='ubuntu-22.04'}}
if: ${{ matrix.os=='ubuntu-22.04' || matrix.os=='macos-11' }}
id: yarn-cache-dir-path-unix
run: echo "dir=$(yarn cache dir)" >> ${GITHUB_OUTPUT}

Expand All @@ -54,7 +54,7 @@ jobs:
${{ runner.os }}-yarn-
- uses: actions/cache@v4
if: ${{ matrix.os=='ubuntu-22.04'}}
if: ${{ matrix.os=='ubuntu-22.04' || matrix.os=='macos-11' }}
id: yarn-cache-unix
with:
path: ${{ steps.yarn-cache-dir-path-unix.outputs.dir }}
Expand All @@ -68,7 +68,9 @@ jobs:
- name: Run linter
run: yarn lint:check

# skip formatter on windows
- name: Run formatter
if: ${{ matrix.os=='ubuntu-22.04' || matrix.os=='macos-11' }}
run: yarn format:check

- name: Run tests
Expand Down

0 comments on commit 02b1c1a

Please sign in to comment.