Skip to content

Commit

Permalink
label fixes and demo feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Charlie Drage <[email protected]>
  • Loading branch information
cdrage authored and deboer-tim committed Jan 11, 2024
1 parent 2a2abf6 commit 0c83ca4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@
"dashboard/image": [
{
"command": "bootc.image.build",
"title": "Build Disk Image"
"title": "Build Disk Image",
"when": "ostree.bootable in imageLabelKeys"
},
{
"command": "bootc.vfkit",
"title": "Launch VM"
"title": "Launch as VM"
}
]
},
Expand Down
4 changes: 2 additions & 2 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export async function activate(extensionContext: ExtensionContext): Promise<void
// Only if success = true and type = ami
if ((successful && selectedType === 'ami') || selectedType === 'raw') {
const result = await extensionApi.window.showInformationMessage(
`Success! Your Bootable OS Container has been succesfully created to ${imagePath}\n\n\nWould you like to convert ${selectedType} to raw and launch with vfkit?`,
`Success! Your Bootable OS Container has been succesfully created to ${imagePath}\n\n\nWould you like to launch with vfkit?`,
'Yes',
'Cancel',
);
Expand Down Expand Up @@ -312,7 +312,7 @@ $IMAGE
SecurityOpt: ['label=type:unconfined_t'],
Binds: [folder + ':/tmp/' + type],
},
//Labels,
Labels,
// Outputs to:
// <type>/disk.<type>
// in the directory provided
Expand Down

0 comments on commit 0c83ca4

Please sign in to comment.