Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-arch support: Detect manifest, extract which image to be used and then build with bib #324

Closed
cdrage opened this issue Apr 11, 2024 · 2 comments · Fixed by #356
Closed

Multi-arch support: Detect manifest, extract which image to be used and then build with bib #324

cdrage opened this issue Apr 11, 2024 · 2 comments · Fixed by #356
Assignees
@cdrage
Labels
kind/feature 💡 Issue for requesting a new feature

Comments

@cdrage
Copy link
Contributor

cdrage commented Apr 11, 2024

Is your feature request related to a problem? Please describe

We are trying to implement manifests into this extension.

The caveat is that we cannot directly pass in manifests to bootc-image-builder. This will not be supported due to upstream issues with the go library.

We should support being able to build from a manifest and use the correct image.

Describe the solution you'd like

In order to do this we will:

  1. Create the manifest via PD / CLI
  2. List the images within this extension
  3. If manifest, inspect the manifest
  4. Get the digest id that matches the architecture selected
  5. List images information and get the image id that matches the digest id
  6. (TEMPORARY WORKAROUND UNTIL FIXED) bib does not support passing in a direct image id, we will have to copy / or rename the image to something like foobar
  7. Pass in the image id / name and bib will build it successfully.

Describe alternatives you've considered

No response

Additional context

No response
@cdrage cdrage added the kind/feature 💡 Issue for requesting a new feature label Apr 11, 2024
@cdrage cdrage self-assigned this Apr 11, 2024
@cdrage cdrage moved this to 📋 Backlog in Podman Desktop Planning Apr 11, 2024
@cdrage cdrage moved this from 📋 Backlog to 🚧 In Progress in Podman Desktop Planning Apr 15, 2024
This was referenced Apr 16, 2024
Merged
Closed
Closed
Closed
@cdrage
Copy link
Contributor Author

cdrage commented Apr 18, 2024

Catching up with @kingsleyzissou this will now be achievable within bootc-image-builder!

It has been tested in osbuild/images#595 (see latest comments)

For the implementation, we will have to support listing manifests as well as using inspectManifest in order to achieve multi-platform selection.

This was referenced Apr 19, 2024
Closed
Merged
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 19, 2024
@cdrage
feat: add manifest / multi-arch selection support
5d685f1 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 19, 2024
@cdrage
feat: add manifest / multi-arch selection support
6cc869b 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 22, 2024
@cdrage
feat: add manifest / multi-arch selection support
f7bcb0e 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 22, 2024
@cdrage
feat: add manifest / multi-arch selection support
f0c98db 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 23, 2024
@cdrage
feat: add manifest / multi-arch selection support
8357c61 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 23, 2024
@cdrage
feat: add manifest / multi-arch selection support
3420ce5 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 24, 2024
@cdrage
feat: add manifest / multi-arch selection support
b99db29 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 25, 2024
@cdrage
feat: add manifest / multi-arch selection support
80fd58f 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 25, 2024
@cdrage
feat: add manifest / multi-arch selection support
f016b0b 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 25, 2024
@cdrage
feat: add manifest / multi-arch selection support
a523999 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 25, 2024
@cdrage
feat: add manifest / multi-arch selection support
ccd6548 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 25, 2024
@cdrage
feat: add manifest / multi-arch selection support
ce1a842 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
@cdrage
Copy link
Contributor Author

cdrage commented Apr 26, 2024

Friday update: osbuild/bootc-image-builder#397 is the last part to go in, once that is merged, we will have to wait for a few hours for konflux to push a new bootc-image-builder image and then we are good to go for updating the PR #356 for full support!

cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 27, 2024
@cdrage
feat: add manifest / multi-arch selection support
04b744b 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
cdrage added a commit to cdrage/podman-desktop-extension-bootc that referenced this issue Apr 27, 2024
@cdrage
feat: add manifest / multi-arch selection support
7be240c 
### What does this PR do?

* Manifests are now listed, inspected and propagated within the Build
  page
* Simply select a manifest, select the arch and it will build

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#324

### How to test this PR?

<!-- Please explain steps to reproduce -->

Follow the video above, or do the following tests:

1. Build a manifest within Podman Desktop (select two architectures, and
   build a bootc image). Must use the latest Podman Desktop
2. Select the manifest within the extension and see it build.

Signed-off-by: Charlie Drage <[email protected]>
@github-project-automation github-project-automation bot moved this from 🚧 In Progress to ✔️ Done in Podman Desktop Planning Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrage cdrage

Labels
kind/feature 💡 Issue for requesting a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add manifest / multi-arch selection support cdrage/podman-desktop-extension-bootc
1 participant
@cdrage