Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial light mode support #536

Closed
deboer-tim opened this issue Jun 11, 2024 · 2 comments
Closed

Initial light mode support #536

deboer-tim opened this issue Jun 11, 2024 · 2 comments
Assignees
@cdrage @deboer-tim
Labels
kind/enhancement ✨ Issue for requesting an improvement kind/epic ⚡ Issue describing an epic

Comments

@deboer-tim
Copy link
Contributor

Is your enhancement related to a problem? Please describe

Most light mode support is coming just by reusing components from Podman Desktop, but we're now in the odd place where if we release with the new library components and Podman Desktop starts exposing experimental light mode support, some of the main text and UI in this extension will switch to light mode and expose some issues.

Describe the solution you'd like

Adopt light mode for most of the UI that we won't get for free from the components - picking up existing style colors from variables.

Describe alternatives you've considered

No response

Additional context

No response
@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Jun 11, 2024
@cdrage
Copy link
Contributor

cdrage commented Jun 12, 2024

Split into two issues:

@deboer-tim deboer-tim added the kind/epic ⚡ Issue describing an epic label Jun 12, 2024
This was referenced Jun 24, 2024
Closed
Closed
deboer-tim added a commit that referenced this issue Aug 6, 2024
@deboer-tim
chore: light mode for delete button, remove drop down
ccd93d0 
We cannot complete #376 because the issue to provide the component has stalled:
podman-desktop/podman-desktop#6898

In the meantime we can do two things:
- Pick up light mode support by copying the current code from Podman Desktop.
- Remove the menu property, so that we can remove the unused dependency on the
  the DropdownMenuItem component. (if we need dropdown support in the future,
  we should use/require the component)

Related to #376.
Part of #536.
Fixes #371.

Signed-off-by: Tim deBoer <[email protected]>
@deboer-tim deboer-tim mentioned this issue Aug 6, 2024
Merged
@deboer-tim
Copy link
Contributor Author

Fixing a minor issue with #709, but the rest of this is complete. Marking done and closing.

cdrage pushed a commit that referenced this issue Aug 6, 2024
@deboer-tim
chore: light mode for delete button, remove drop down (#709)
7df2443 
We cannot complete #376 because the issue to provide the component has stalled:
podman-desktop/podman-desktop#6898

In the meantime we can do two things:
- Pick up light mode support by copying the current code from Podman Desktop.
- Remove the menu property, so that we can remove the unused dependency on the
  the DropdownMenuItem component. (if we need dropdown support in the future,
  we should use/require the component)

Related to #376.
Part of #536.
Fixes #371.

Signed-off-by: Tim deBoer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrage cdrage

@deboer-tim deboer-tim

Labels
kind/enhancement ✨ Issue for requesting an improvement kind/epic ⚡ Issue describing an epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdrage @deboer-tim