chore: light mode for delete button, remove drop down #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot complete #376 because the issue to provide the component has stalled: podman-desktop/podman-desktop#6898 In the meantime we can do two things: - Pick up light mode support by copying the current code from Podman Desktop. - Remove the menu property, so that we can remove the unused dependency on the the DropdownMenuItem component. (if we need dropdown support in the future, we should use/require the component) Related to #376. Part of #536. Fixes #371. Signed-off-by: Tim deBoer <[email protected]>
|
Tested and LGTM! |
cdrage
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We cannot complete #376 because the issue to provide the component has stalled: podman-desktop/podman-desktop#6898
In the meantime we can do two things:
Screenshot / video of UI
Minor - in light mode the delete button looks almost disabled before, with color variables it is black.
What issues does this PR fix or reference?
Related to #376.
Part of #536.
Fixes #371.
How to test this PR?
Just look at homepage in light mode.