Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove vfkit from package.json #109

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Jan 29, 2024

chore: remove vfkit from package.json

What does this PR do?

Removes vfkit from package.json (for now) until we explore more stable
options / stability issues with it.

Right now we should be informing the user how to launch it via docs
instead.

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

N/A

How to test this PR?

Buttons should no longer be there.

Signed-off-by: Charlie Drage [email protected]

### What does this PR do?

Removes vfkit from package.json (for now) until we explore more stable
options / stability issues with it.

Right now we should be informing the user how to launch it via docs
instead.

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

N/A

### What issues does this PR fix or reference?

N/A

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

### How to test this PR?

Buttons should no longer be there.

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>
Copy link
Contributor

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it :).

@cdrage cdrage merged commit a644ebb into podman-desktop:main Jan 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants