chore: add telemetry for examples #1098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What does this PR do? Adds telemetry for building as well as pulling examples ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> N/A ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#1047 ### How to test this PR? <!-- Please explain steps to reproduce --> Functions on example should work as normal. Signed-off-by: Charlie Drage <[email protected]>
cdrage
requested review from
benoitf,
jeffmaury and
axel7083
and removed request for
a team
|
If you can double-check that I did this right, please let me know! First time adding telemetry. |
axel7083
reviewed
Dec 16, 2024
| @@ -90,10 +91,16 @@ test('pullImage function is called when Pull image button is clicked', async () | |||
|
|
|||
| // Find and click the "Pull image" button | |||
| const pullButton = screen.getByTitle('Pull image'); | |||
|
|
|||
| // spy on telemetryLogUsage function | |||
| const spyOnLogUsage = vi.spyOn(bootcClient, 'telemetryLogUsage'); | |||
There was a problem hiding this comment.
You can probably do vi.mocked(bootcClient.telemetryLogUsage) and expect(bootcClient.telemetryLogUsage).toHaveBeenCalled()
jeffmaury
reviewed
Dec 16, 2024
| @@ -90,10 +91,16 @@ test('pullImage function is called when Pull image button is clicked', async () | |||
|
|
|||
| // Find and click the "Pull image" button | |||
| const pullButton = screen.getByTitle('Pull image'); | |||
|
|
|||
| // spy on telemetryLogUsage function | |||
| vi.mocked(bootcClient.telemetryLogUsage); | |||
There was a problem hiding this comment.
I don't get why this is required ?
There was a problem hiding this comment.
you're right, not required! updated the PR.
Signed-off-by: Charlie Drage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: add telemetry for examples
What does this PR do?
Adds telemetry for building as well as pulling examples
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Closes #1047
How to test this PR?
Functions on example should work as normal.
Signed-off-by: Charlie Drage [email protected]