chore: revert back to vite 5 + update vitest #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What does this PR do? There are numerous issues updating to vite 6 is causing us: * Issues with proper vitest and a failing test * Blank pages for the extension * Being forced to use a beta version of vitest to have it build correctly. ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#1107 ### How to test this PR? <!-- Please explain steps to reproduce --> Be able to use the extension (using pnpm watch and passing in extension folder) and not having a blank page. Signed-off-by: Charlie Drage <[email protected]>
cdrage
requested review from
benoitf,
feloy and
gastoner
and removed request for
a team
benoitf
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: revert back to vite 5 + update vitest
What does this PR do?
There are numerous issues updating to vite 6 is causing us:
correctly.
Screenshot / video of UI
Screen.Recording.2024-12-19.at.10.52.46.AM.mov
What issues does this PR fix or reference?
Closes #1107
How to test this PR?
Be able to use the extension (using pnpm watch and passing in extension
folder) and not having a blank page.
Signed-off-by: Charlie Drage [email protected]