Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change name #127

Merged
merged 1 commit into from
Feb 4, 2024
Merged

fix: change name #127

merged 1 commit into from
Feb 4, 2024

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Feb 4, 2024

What does this PR do?

bootc extension is published as redhat.bootc in the catalog so it should match the name of the package.json as well
or we change the catalog to use redhat.bootc-extension

so when installing the extension we're not finding the right extension after so some buttons are not replaced/ arestill in progress/etc

Screenshot / video of UI

What issues does this PR fix or reference?

podman-desktop/podman-desktop#5759

How to test this PR?

bootc extension is published as `redhat.bootc` in the catalog so it should match the name of the package.json as well

or we change the catalog to use `redhat.bootc-extension`

Signed-off-by: Florent Benoit <[email protected]>
@benoitf
Copy link
Contributor Author

benoitf commented Feb 4, 2024

if you could cut a new release after this change so we can update the catalog

Copy link
Contributor

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will just check with Charlie and do a new release tomorrow.

@deboer-tim deboer-tim merged commit b442000 into main Feb 4, 2024
4 checks passed
@deboer-tim deboer-tim deleted the fix-name branch February 4, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants