Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove old builder images #144

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

deboer-tim
Copy link
Contributor

What does this PR do?

Adds a new function to delete images with a given name that do not have the same tag (nor a second tag; you can tag to keep something). Uses this to look for and clean up any old builder images, so that we'll automatically clean up whenever we pull a new one.

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

Fixes #98.

How to test this PR?

Pull the 'latest' bootc builder image and then build a new disk image, 'latest' will be deleted since we're using a tagged one.

Adds a new function to delete images with a given name that do not
have the same tag (nor a second tag; you can tag to keep something).
Uses this to look for and clean up any old builder images, so that
we'll automatically clean up whenever we pull a new one.

Fixes podman-desktop#98.

Signed-off-by: Tim deBoer <[email protected]>
@deboer-tim deboer-tim requested a review from a team as a code owner February 13, 2024 19:15
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise LGTM! Worked well and it successfully deleted the previous copies.

src/container-utils.ts Show resolved Hide resolved
@cdrage cdrage enabled auto-merge (squash) February 15, 2024 14:04
@cdrage cdrage merged commit f3f2e3f into podman-desktop:main Feb 15, 2024
4 checks passed
@deboer-tim deboer-tim deleted the old-images branch March 28, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up old builder images
2 participants