-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip / do not merge] feat: form page / webview component for bootc #153
Conversation
Some other notes which are covered in different issues: |
8e54e1b
to
052c177
Compare
### What does this PR do? Our first ever form page! This is a massive PR / "initiliazation" PR to get our form page started. It includes some basic features and a working, functional form page that: * Checks what images are available / listed and filters out non-bootc ones * Submit it and have it running in the background There are also some significant architectural changes: * Shared / frontend / backend folders that demonstrate each section of the extension, in order to do cross-communication between the webview and backend * Refactoring of the "quickpick" so it is now separate from the other functionalities of the extension and is still useable. It is now in a separate function that just gets the users input from quickpick To note: * There may be some validation that is still needed / to test / try to "break" the form ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#141 ### How to test this PR? <!-- Please explain steps to reproduce --> 1. `yarn watch` or `yarn build` in the extension folder 2. You MAY have to do `yarn install` or `yarn` in both the root folder, and `packages/frontend` and `packages/backend` for it to work correctly. 3. Go to the LATEST changes on the main branch of podman desktop, and run `yarn watch --extension-folder ../bootc/packages/backend` Signed-off-by: Charlie Drage <[email protected]>
fb31161
to
8261f25
Compare
hello, to avoid the could you do iterative stuff for example, move the current code to a backend package (no code change except the move to a subfolder) so lot of stuff could already be merged |
Will do! This is just a draft / WIP to show progress. |
a1f53c2
to
39be047
Compare
yes but usually when you'll reach the end of the draft it will result in a PR being too big new directories, new dependencies, etc, all of that could already be started to be integrated without breaking the current behaviour |
I understand, this is just a WIP / draft with all the code and intended changes for demo purposes. This will be pushed in multiple other PRs in the future. |
I am closing this PR for now @feloy so that this does not cluster up the PR list. Expect some smaller PR's next week 👍 |
feat: form page / webview component for bootc
What does this PR do?
Our first ever form page!
This is a massive PR / "initiliazation" PR to get our form page started.
It includes some basic features and a working, functional form page
that:
ones
There are also some significant architectural changes:
the extension, in order to do cross-communication between the webview
and backend
functionalities of the extension and is still useable. It is now in a
separate function that just gets the users input from quickpick
To note:
"break" the form
Screenshot / video of UI
Screen.Recording.2024-02-17.at.11.48.18.AM.mov
What issues does this PR fix or reference?
Closes #141
How to test this PR?
yarn watch
oryarn build
in the extension folderyarn install
oryarn
in both the root folder,and
packages/frontend
andpackages/backend
for it to workcorrectly.
run
yarn watch --extension-folder ../bootc/packages/backend
Signed-off-by: Charlie Drage [email protected]