Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip / do not merge] feat: form page / webview component for bootc #153

Closed
wants to merge 2 commits into from

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Feb 17, 2024

feat: form page / webview component for bootc

What does this PR do?

Our first ever form page!

This is a massive PR / "initiliazation" PR to get our form page started.

It includes some basic features and a working, functional form page
that:

  • Checks what images are available / listed and filters out non-bootc
    ones
  • Submit it and have it running in the background

There are also some significant architectural changes:

  • Shared / frontend / backend folders that demonstrate each section of
    the extension, in order to do cross-communication between the webview
    and backend
  • Refactoring of the "quickpick" so it is now separate from the other
    functionalities of the extension and is still useable. It is now in a
    separate function that just gets the users input from quickpick

To note:

  • There may be some validation that is still needed / to test / try to
    "break" the form

Screenshot / video of UI

Screen.Recording.2024-02-17.at.11.48.18.AM.mov

What issues does this PR fix or reference?

Closes #141

How to test this PR?

  1. yarn watch or yarn build in the extension folder
  2. You MAY have to do yarn install or yarn in both the root folder,
    and packages/frontend and packages/backend for it to work
    correctly.
  3. Go to the LATEST changes on the main branch of podman desktop, and
    run yarn watch --extension-folder ../bootc/packages/backend

Signed-off-by: Charlie Drage [email protected]

@cdrage cdrage requested a review from a team as a code owner February 17, 2024 16:57
@cdrage cdrage marked this pull request as draft February 17, 2024 17:05
@cdrage
Copy link
Contributor Author

cdrage commented Feb 17, 2024

@cdrage cdrage force-pushed the add-webview branch 4 times, most recently from 8e54e1b to 052c177 Compare February 20, 2024 21:16
### What does this PR do?

Our first ever form page!

This is a massive PR / "initiliazation" PR to get our form page started.

It includes some basic features and a working, functional form page
that:

* Checks what images are available / listed and filters out non-bootc
  ones
* Submit it and have it running in the background

There are also some significant architectural changes:
* Shared / frontend / backend folders that demonstrate each section of
  the extension, in order to do cross-communication between the webview
  and backend
* Refactoring of the "quickpick" so it is now separate from the other
  functionalities of the extension and is still useable. It is now in a
  separate function that just gets the users input from quickpick

To note:

* There may be some validation that is still needed / to test / try to
  "break" the form

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#141

### How to test this PR?

<!-- Please explain steps to reproduce -->

1. `yarn watch` or `yarn build` in the extension folder
2. You MAY have to do `yarn install` or `yarn` in both the root folder,
   and `packages/frontend` and `packages/backend` for it to work
   correctly.
3. Go to the LATEST changes on the main branch of podman desktop, and
   run `yarn watch --extension-folder ../bootc/packages/backend`

Signed-off-by: Charlie Drage <[email protected]>
@cdrage cdrage force-pushed the add-webview branch 2 times, most recently from fb31161 to 8261f25 Compare February 26, 2024 22:21
@benoitf
Copy link
Contributor

benoitf commented Feb 27, 2024

hello, to avoid the This is a massive PR / "initiliazation" PR

could you do iterative stuff

for example, move the current code to a backend package (no code change except the move to a subfolder)
then you can introduce frontend module (can be empty and not used)
etc

so lot of stuff could already be merged

@cdrage
Copy link
Contributor Author

cdrage commented Feb 27, 2024

hello, to avoid the This is a massive PR / "initiliazation" PR

could you do iterative stuff

for example, move the current code to a backend package (no code change except the move to a subfolder)

then you can introduce frontend module (can be empty and not used)

etc

so lot of stuff could already be merged

Will do! This is just a draft / WIP to show progress.

@cdrage cdrage force-pushed the add-webview branch 8 times, most recently from a1f53c2 to 39be047 Compare February 29, 2024 15:46
@benoitf
Copy link
Contributor

benoitf commented Feb 29, 2024

Will do! This is just a draft / WIP to show progress.

yes but usually when you'll reach the end of the draft it will result in a PR being too big
so you should start to issue small chunks as soon as possible.

new directories, new dependencies, etc, all of that could already be started to be integrated without breaking the current behaviour

@cdrage cdrage changed the title feat: form page / webview component for bootc [wip / do not merge] feat: form page / webview component for bootc Feb 29, 2024
@cdrage
Copy link
Contributor Author

cdrage commented Feb 29, 2024

Will do! This is just a draft / WIP to show progress.

yes but usually when you'll reach the end of the draft it will result in a PR being too big

so you should start to issue small chunks as soon as possible.

new directories, new dependencies, etc, all of that could already be started to be integrated without breaking the current behaviour

I understand, this is just a WIP / draft with all the code and intended changes for demo purposes.

This will be pushed in multiple other PRs in the future.

@cdrage
Copy link
Contributor Author

cdrage commented Feb 29, 2024

I am closing this PR for now @feloy so that this does not cluster up the PR list.

Expect some smaller PR's next week 👍

@cdrage cdrage closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adds custom build image page
2 participants