feature: automatically select image based on image architecture inspect #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What does this PR do? * Automatically selects the image based upon what architecture is available under inspect image. Note that this is also in anticipation of manifest feature being added, so there is some code in here (such as an array, rather than a single string) for manifest. ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#245 ### How to test this PR? Open a build, try and click on arm64 / amd64. <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <[email protected]>
cdrage
force-pushed
the
auto-detect-image
branch
from
a876d6c to
6de6d63
Compare
deboer-tim
approved these changes
Apr 22, 2024
| @@ -66,6 +73,24 @@ async function fillBuildOptions() { | |||
| } | |||
| } | |||
|
|
|||
| async function fillArchitectures(historyInfo: BootcBuildInfo[]) { | |||
There was a problem hiding this comment.
There's a lot of overlap with fillBuildOptions, which even sets buildArch in one case. It's fine as-is, but I think they should probably be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: automatically select image based on image architecture inspect
What does this PR do?
available under inspect image.
Note that this is also in anticipation of manifest feature being added,
so there is some code in here (such as an array, rather than a single
string) for manifest.
Screenshot / video of UI
Screen.Recording.2024-04-18.at.4.53.53.PM.mov
What issues does this PR fix or reference?
Closes #245
How to test this PR?
Open a build, try and click on arm64 / amd64.
Signed-off-by: Charlie Drage [email protected]