Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add gif of example images, small explanation #412

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Apr 29, 2024

docs: add gif of example images, small explanation

What does this PR do?

  • Adds gif on how to pull our test image
  • Adds link to our VM guide on how to test it after building

Screenshot / video of UI

N/A, see doc

What issues does this PR fix or reference?

Closes #342

How to test this PR?

N/A, doc

Signed-off-by: Charlie Drage [email protected]

@cdrage cdrage requested a review from a team as a code owner April 29, 2024 18:44
Copy link
Contributor

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think vm_guide would also need to be an absolute link to work from inside the catalog?

@benoitf
Copy link
Contributor

benoitf commented Apr 29, 2024

FYI I see 10 links starting in the markdown with (/(relative links that will fail)

### What does this PR do?

* Adds gif on how to pull our test image
* Adds link to our VM guide on how to test it after building

### Screenshot / video of UI

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

N/A, see doc

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

Closes podman-desktop#342

### How to test this PR?

<!-- Please explain steps to reproduce -->

N/A, doc

Signed-off-by: Charlie Drage <[email protected]>
@cdrage
Copy link
Contributor Author

cdrage commented Apr 29, 2024

I have updated this PR to add the absolute links. The rest of the absolute links will be added with #411

@benoitf @deboer-tim

@deboer-tim deboer-tim merged commit 3161ef9 into podman-desktop:main Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document our example image (bootc-extension:httpd)
3 participants