feature: detect fedora image and update filesystem #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested changes
May 21, 2024
| </p> | ||
| {#if fedoraDetected} | ||
| <p class="text-gray-300 text-xs"> | ||
| Fedora detected. By default Fedora requires a specific filesystem to be selected. XFS is recommended. |
There was a problem hiding this comment.
Isn't 'by default' extraneous? Are there any cases where Fedora doesn't need a filesystem selected?
### What does this PR do? * Detects if the base image is based upon fedora * If it is based on fedora, auto-select the filesystem ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#457 ### How to test this PR? <!-- Please explain steps to reproduce --> Select a fedora bootc image or manifest, it will auto-select XFS. If you select a non-fedora bootc image, it will be default. Tests also cover new feature Signed-off-by: Charlie Drage <[email protected]>
|
@deboer-tim Updated with the changes (removed the debugging, updated the fedora detected description) |
deboer-tim
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: detect fedora image and update filesystem
What does this PR do?
Screenshot / video of UI
Screen.Recording.2024-05-21.at.4.28.57.PM.mov
What issues does this PR fix or reference?
Closes #457
How to test this PR?
Select a fedora bootc image or manifest, it will auto-select XFS.
If you select a non-fedora bootc image, it will be default.
Tests also cover new feature
Signed-off-by: Charlie Drage [email protected]