chore: add build to PR check #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed with Charlie. We're not entirely sure what a build will catch over the existing lint/test, but since we're doing it post-merge it's better to know that it passed in the PR. Signed-off-by: Tim deBoer <[email protected]>
benoitf
requested changes
Jan 19, 2024
benoitf
approved these changes
Jan 19, 2024
benoitf
reviewed
Jan 19, 2024
benoitf
reviewed
Jan 19, 2024
deboer-tim
force-pushed
the
pr-check-build
branch
from
8f2138f to
6465ce1
Compare
Signed-off-by: Tim deBoer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Discussed with Charlie. We're not entirely sure what a build will catch over the existing lint/test, but since we're doing it post-merge it's better to know that it passed in the PR.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Part of #24.
How to test this PR?
See PR status.