feat: add chown (linux only) #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI based on #684 since it requires certain Linux features to be in for this to work. |
|
|
deboer-tim
reviewed
Aug 1, 2024
|
@deboer-tim added chown detection / fill in with a new commit |
### What does this PR do? * Adds chown to the advanced settings page for build * Only applicable to Linux (see: osbuild/bootc-image-builder#576) ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Closes podman-desktop#472 ### How to test this PR? <!-- Please explain steps to reproduce --> 1. Be on Linux 2. Build an image 3. See that it is chown (ex. ls -l /outputdir) Signed-off-by: Charlie Drage <[email protected]>
Signed-off-by: Charlie Drage <[email protected]>
deboer-tim
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add chown (linux only)
What does this PR do?
chown doesn't work on mac or windows? osbuild/bootc-image-builder#576)
Screenshot / video of UI
What issues does this PR fix or reference?
Closes #472
How to test this PR?
Signed-off-by: Charlie Drage [email protected]