feat: add launch action to bootable images

[deboer-tim]

What does this PR do?

Now that we clean up after a successful build, there's no way to launch vfkit on the image. This adds a command to bootable images, which tries to launch vfkit against the last disk image build.

Screenshot / video of UI

What issues does this PR fix or reference?

Fixes part of #18.

How to test this PR?

Launch the action on a bootable container that you haven't built before (it fails), then build an image and retry.

[cdrage]

It worked!

Had no issues launching the previous image via vfkit. So all of this LGTM. Thanks for adding it to the image list instead.

Only change is we need to update the package.json as well to remove it from container page.

[cdrage]

we should also remove the previous part about it being in container page: https://github.com/containers/podman-desktop-extension-bootc/blob/b275f8ff58183aaa2c2de0fea9821f1ea070623d/package.json#L28

[jwboyer]

I gave this PR a try because the build container is cleaned up too quickly so there's no opportunity to start it from that screen. I merged it locally with #91 also included. I built a disk image successfully and then tried to launch it and it failed. This is the command it produced:

main ↪️ [bootc-extension] --cpus,2,--memory,2048,--bootloader,efi,variable-store=./efi-variable-store,create,--device,virtio-blk,path=/Users/jboyer/images/jwboyer-eln,--device,virtio-serial,logFilePath=/Users/jboyer/images/vfkit-serial.log,--device,virtio-net,nat,mac=72:20:43:d4:38:62,--device,virtio-rng,--device,virtio-input,keyboard,--device,virtio-input,pointing,--device,virtio-gpu,width=1920,height=1080,--gui

Note the virtio-blk,path specified didn't include the ...../images/disk.raw part.

I looked at the code and it seems like we're passing the selectedFolder into history and not the actual image path. I tried this diff and it at least tried to launch the VM:

diff --git a/src/build-disk-image.ts b/src/build-disk-image.ts
index 0854399..2a2e53b 100644
--- a/src/build-disk-image.ts
+++ b/src/build-disk-image.ts
@@ -88,7 +88,7 @@ export async function buildDiskImage(imageData: unknown, history: History) {
   }
 
   // store this path for later
-  await history.addImageBuild(image.name, selectedType, selectedFolder);
+  await history.addImageBuild(image.name, selectedType, imagePath);
 
   return extensionApi.window.withProgress(
     { location: extensionApi.ProgressLocation.TASK_WIDGET, title: 'Building disk image ' + image.name },

The VM doesn't actually boot, but at least the vfkit invocation is correct.

[jwboyer]

FWIW, here's a screenshot of the VM after the changes mentioned above:

and the command that was run:
main ↪️ [bootc-extension] --cpus,2,--memory,2048,--bootloader,efi,variable-store=./efi-variable-store,create,--device,virtio-blk,path=/Users/jboyer/images/jwboyer-eln/image/disk.raw,--device,virtio-serial,logFilePath=/Users/jboyer/images/jwboyer-eln/image/vfkit-serial.log,--device,virtio-net,nat,mac=72:20:43:d4:38:62,--device,virtio-rng,--device,virtio-input,keyboard,--device,virtio-input,pointing,--device,virtio-gpu,width=1920,height=1080,--gui

Not sure if this is an issue with the disk itself, or something with vfkit

[cdrage]

FWIW, here's a screenshot of the VM after the changes mentioned above:

and the command that was run: `main ↪️ [bootc-extension] --cpus,2,--memory,2048,--bootloader,efi,variable-store=./efi-variable-store,create,--device,virtio-blk,path=/Users/jboyer/images/jwboyer-eln/image/disk.raw,--device,virtio-serial,logFilePath=/Users/jboyer/images/jwboyer-eln/image/vfkit-serial.log,--device,virtio-net,nat,mac=72:20:43:d4:38:62,--device,virtio-rng,--device,virtio-input,keyboard,--device,virtio-input,pointing,--device,virtio-gpu,width=1920,height=1080,--gui`

Not sure if this is an issue with the disk itself, or something with vfkit

Press enter :)

This unfortunately is an issue with bootc-image-builder at the moment where it is getting "stuck" on the VM load: osbuild/bootc-image-builder#105 and the screen isn't correctly refreshing.

They are at the moment working on improving the kernel parameters / templating the bootc image builder so that it would work correctly.

[jwboyer]

Not sure if this is an issue with the disk itself, or something with vfkit

Press enter :)

I tried that before reporting 😄 Didn't do anything.

This unfortunately is an issue with bootc-image-builder at the moment where it is getting "stuck" on the VM load: osbuild/bootc-image-builder#105 and the screen isn't correctly refreshing.

They are at the moment working on improving the kernel parameters / templating the bootc image builder so that it would work correctly.

OK. I can be patient. Thanks for the pointer.

[deboer-tim]

As per comments elsewhere, we would love to provide options to test or run the disk image after building, but vfkit continued to have problems for users, and we have found no stable/open-source/compatible enough alternative. I'm finally withdrawing this PR, and we can follow up with new issues if there's another option.