Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add headlamp to list of extensions #39

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

yolossn
Copy link
Contributor

@yolossn yolossn commented Apr 23, 2024

No description provided.

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @yolossn and thanks for your contribution

do you have tested the extension within Podman Desktop ?

api/extensions.json Outdated Show resolved Hide resolved
api/extensions.json Outdated Show resolved Hide resolved
@yolossn yolossn requested a review from benoitf April 27, 2024 13:43
@yolossn
Copy link
Contributor Author

yolossn commented Apr 30, 2024

gentle ping @benoitf

@benoitf
Copy link
Contributor

benoitf commented Apr 30, 2024

@yolossn I saw you pinged me but AFAIK you've not replied if you tested and how you tested it in Podman Desktop ?

@yolossn
Copy link
Contributor Author

yolossn commented Apr 30, 2024

@benoitf sorry, I missed that comment. I tested it by installing the extension from the Desktop Extension settings.
image

Attaching few screenshots of headlamp extension working in Podman Desktop
image
image

@benoitf
Copy link
Contributor

benoitf commented May 1, 2024

thanks @yolossn I'll merge the PR in 7 days

@yolossn
Copy link
Contributor Author

yolossn commented May 15, 2024

@benoitf May I know if Headlamp will be listed in Podman Desktop after the PR is merged or will it appear only from the next release.

@benoitf
Copy link
Contributor

benoitf commented May 15, 2024

@yolossn it will appear after the merge (you may have to restart Podman Desktop as there is a local cache for some hours)

api/extensions.json Outdated Show resolved Hide resolved
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf
Copy link
Contributor

benoitf commented Jun 10, 2024

oops forgot to merge it !

@benoitf benoitf merged commit cb44e3d into podman-desktop:gh-pages Jun 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants