Remove tca in favor of combine-only approach to core location dependencies #40
+102
−312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior PR I pushed fixed up usage of the library with TCA 0.57-0.59, but using the library still results in warnings that cannot be resolved in apps that use it (namely, that effects conforming to publisher is deprecated). In an effort to remove warnings from apps that use the library, I figured a refactor to just use combine types instead of effectpublisher would be a useful thing to have. Is this something that might be desired in an official release of this library?
I opted to not go the AsyncSequence route since there's not an official way to create a shared stream with multiple subscribers yet, and I suspect that accidentally creating multiple subscribers to one for this library would cause a lot of hard to diagnose issues.
If this is a welcome change, the demo project will still need updating to get CI to work but I'm happy to do that too.