Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Add QFN-16_1EP_3x3mm_P0.5mm_EP1.6x1.6mm #485

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Add QFN-16_1EP_3x3mm_P0.5mm_EP1.6x1.6mm #485

merged 1 commit into from
Feb 21, 2020

Conversation

whitequark
Copy link
Contributor

@whitequark whitequark mentioned this pull request Jan 12, 2020
Merged
5 tasks
@codeclimate
Copy link

codeclimate bot commented Jan 12, 2020 •
edited
Loading

Code Climate has analyzed commit 6c03fd3 and detected 0 issues on this pull request.

View more on Code Climate.

@chschlue
Copy link
Collaborator

Pending #422

@whitequark
Copy link
Contributor Author

@chschlue #422 is merged--is there anything I need to do here?

@chschlue
Copy link
Collaborator

chschlue commented Feb 6, 2020

You need to regenerate KiCad/kicad-footprints#2049 using the current scripts (i.e. past-422.)
Also, this PR has to be reviewed before 2049 can be merged (meaning 2049 can wait until your size definitions here have been verified so you don't have to update the FP PR twice.)

chschlue
chschlue suggested changes Feb 8, 2020
View reviewed changes
scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON/size_definitions/qfn/qfn-1x.yaml Outdated
@@ -170,6 +170,39 @@ QFN-16-1EP_3x3mm_P0.5mm_EP1.45x1.45mm:
#suffix: '_Pad{pad_x:.2f}x{pad_y:.2f}mm_HandSolder'
#include_suffix_in_3dpath: 'False'

QFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be called TQFN and moved to tqfn.yaml

scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON/size_definitions/qfn/qfn-1x.yaml Outdated
QFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm:
device_type: 'QFN'
ipc_class: 'qfn'
size_source: 'https://www.diodes.com/assets/Datasheets/PI6C5946002.pdf'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add #page=12

scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON/size_definitions/qfn/qfn-1x.yaml Outdated
maximum: 0.5

EP_size_x: 1.6
EP_size_y: 1.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use package pad dimensions and tolerances as given in the datasheet and then add EP_size_[xy]_overwrite to get a 1.6x1.6mm FP pad.

@whitequark whitequark force-pushed the QFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm branch from 59dea84 to 6c03fd3 Compare February 9, 2020 13:29
@whitequark
Copy link
Contributor Author

Thanks for the review, I've applied all changes.

@chschlue
Copy link
Collaborator

chschlue commented Feb 9, 2020

Looks good now. Please push the new FP to KiCad/kicad-footprints#2049.

@whitequark
Copy link
Contributor Author

Done.

@chschlue
Copy link
Collaborator

chschlue commented Feb 9, 2020

FP merged.

@pointhi pointhi merged commit 991a4ef into pointhi:master Feb 21, 2020
@whitequark whitequark deleted the QFN-16-1EP_3x3mm_P0.5mm_EP1.6x1.6mm branch February 22, 2020 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chschlue chschlue chschlue requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whitequark @chschlue @pointhi