Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update currency pages #182

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Conversation

wormania
Copy link
Contributor

A few improvements to the Currency pages:

  1. Removed unnecessary duplication around shopMon code and made the callers more readable with Currency enum
  2. Moved the Pokémon Dollars page to the proper name, Pokédollars. Went through the repo and cleaned up all the random misspellings of it too.
  3. Optimized the DT page, cut the number of calls to highestRoute from the template in half (150 -> 74) and then cache the results so it's only calculated 18 times in total. Cuts load time of the page significantly

@github-actions github-actions bot added markdown Adding or editing markdown from the data folder html Adding or editing html files script Adding or editing js files labels Jan 21, 2024
@CypherX
Copy link
Contributor

CypherX commented Feb 5, 2024

Looks good, thanks

@CypherX CypherX merged commit 48045a8 into pokeclicker:main Feb 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
html Adding or editing html files markdown Adding or editing markdown from the data folder script Adding or editing js files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants