Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Gem pages, Type-catch quest pages, requirements fix #220

Merged
merged 5 commits into from
Nov 16, 2024

Conversation

wormania
Copy link
Contributor

Gem Pages have been updated for the monotype gem buff, made the information more useful (% means nothing when different mons/encounter types give different numbers of gems), and return the two best locations per region, rather than 1 gym + 1 route (as routes are generally terrible)

image

Gem pages were often used as a proxy for locating specific types for a type-catch quest, however they were poor due to not taking into consideration catch chances, added a tailor-made page for this use:

image

While there are some similarities with the Dungeon Tokens table, I went for simplicity of fetching the current day/weather conditions and calculating from there, and also chose three key datapoints for the catch chance modifiers rather than listing every combination

Finally, added the requirement override which makes all requirements show as incomplete, so the various "less than" requirements that are completed by default now show:
image

@github-actions github-actions bot added html Adding or editing html files script Adding or editing js files labels Nov 16, 2024
@CypherX
Copy link
Contributor

CypherX commented Nov 16, 2024

Just one thing:

Can you add an overview page for "Catch Type Quests", clicking the breadcrumb link goes to a non-existent page
image
image

@github-actions github-actions bot added the markdown Adding or editing markdown from the data folder label Nov 16, 2024
@wormania
Copy link
Contributor Author

Added, I also took the liberty of updating the type badges to match the new style ingame:
image

@CypherX
Copy link
Contributor

CypherX commented Nov 16, 2024

Thanks 👍

@CypherX CypherX merged commit 419b3b4 into pokeclicker:main Nov 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
html Adding or editing html files markdown Adding or editing markdown from the data folder script Adding or editing js files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants