Remove vendor dependencies and cleanup scripts. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SubQL latest release support all the fixes and enhancements that was made by @bryanchriswhite on vendor packages. So there is no need to keep them on the repo and overcomplicate the build process.
Olshansk
reviewed
Aug 5, 2024
Olshansk
reviewed
Aug 5, 2024
Olshansk
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
@jorgecuesta LGTM but please make sure the CI passes before merging it in!
Ensure both architectures are properly built and tested for CI compatibility. Introduced a precommit hook to streamline the process and made necessary amendments to the Dockerfile for ARM64 support.
Fixed |
Olshansk
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request involves a significant change to our project's dependencies. We have used forked versions of the
cosmjsandsubqlpackages.The primary reason behind opting for these forks was to address the compatibility issues with Cosmos SDK version
0.50.x. The official maintainers have since resolved these issues.As such, I have removed the forked
cosmjsandsubqlpackages and replaced them with the official ones. This change aims to ensure our project remains current, reliable, and secure. Additionally, using the official packages enables us to take advantage of future improvements and bug fixes more efficiently.I have thoroughly tested these changes and confirmed that they don't introduce any adverse effects on our project's functionality.
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_testmake test_e2ePR Testing (only if making code changes)
devnet-test-e2elabel to the PR.make trigger_ciif you want to re-trigger tests without any code changesSanity Checklist