Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General enhancements and fix #1 #16

Closed
wants to merge 2 commits into from
Closed

Conversation

jorgecuesta
Copy link
Collaborator

Summary

Issue

Fix #1 and enhancements to the code.

*. Introduced several new .proto files in 'poktroll/application', 'poktroll/proof', 'poktroll/gateway', and 'poktroll/session' directories
*. Updated already existent .proto files of cosmos to the files on cosmos-sdk at v0.50.7
*. Added a new environment variable to add extra params to subquery node
*. Fixed an issue with pgadmin that caused default servers do not be loaded
*. Added lodash and json-bigint dependencies
*. Updated few dependencies to the latest version

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

Documentation changes (only if making doc changes)

  • make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • See quickstart guide for instructions

PR Testing (only if making code changes)

  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
    • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
    • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
    • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

*. Introduced several new .proto files in 'poktroll/application', 'poktroll/proof', 'poktroll/gateway', and 'poktroll/session' directories
*. Updated already existent .proto files of cosmos to the files on cosmos-sdk at v0.50.7
*. Added a new environment variable to add extra params to subquery node
*. Fixed an issue with pgadmin that caused default servers do not be loaded
*. Added lodash and json-bigint dependencies
*. Updated few dependencies to the latest version
@jorgecuesta jorgecuesta self-assigned this Sep 3, 2024
Reformatted imports to use consistent double quotes and added missing semicolons across various files for better code consistency and readability. Also updated `.prettierrc` configuration to enforce these styles.
@jorgecuesta
Copy link
Collaborator Author

@jorgecuesta jorgecuesta closed this Sep 5, 2024
@jorgecuesta jorgecuesta deleted the fix-and-enhancements branch September 5, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Extraneous escaping in EventAttribute#json
1 participant