-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add genesis files and balances #21
Add genesis files and balances #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Please @Olshansk @bryanchriswhite remember the scope of this genesis parsing is only for accounts. Later we will expand to save from Genesis the state of Applications, Gateways, Suppliers, etc.
added comment explaining why to return early in handleGenesis when the block is not the genesis Co-authored-by: Bryan White <[email protected]>
…LE_PATH with GENESIS_FILENAME at env.sample to only specify the file name of the genesis file and updated docker files to support this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing @Alann27, thanks! 🚀 This is great to see. 💪
I just had a couple more small suggestions (one of which is cleaning up my own mistake 😅). Otherwise, this LGTM! 🚢
Summary
Details
Issue
The balances of the genesis accounts were not right because the genesis files was not being indexed.
Type of change
Select one or more:
Sanity Checklist