Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix leak for watch #234

Merged
merged 1 commit into from
Feb 11, 2025
Merged

fix leak for watch #234

merged 1 commit into from
Feb 11, 2025

Conversation

sak0
Copy link
Contributor

@sak0 sak0 commented Feb 11, 2025

Please provide issue(s) of this PR:
Fixes ##225

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

fix leak for watch
ae4e6e2 
Signed-off-by: haozhicui <[email protected]>
@sak0 sak0 requested a review from chuntaojun February 11, 2025 06:14
chuntaojun
chuntaojun approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@chuntaojun chuntaojun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sak0 sak0 merged commit 531342e into polarismesh:main Feb 11, 2025
6 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuntaojun chuntaojun chuntaojun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sak0 @chuntaojun