Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Substrate.io Migration] Tutorials -> Build a Blockchain -> Build a Local Blockchain #14

Merged
merged 16 commits into from
Sep 23, 2024
Merged

[Substrate.io Migration] Tutorials -> Build a Blockchain -> Build a Local Blockchain #14

merged 16 commits into from
Sep 23, 2024

Conversation

0xLucca
Copy link
Collaborator

@0xLucca 0xLucca commented Sep 9, 2024

The "Build a Local Blockchain" page was migrated from the existing Substrate.io Tutorial section: https://docs.substrate.io/tutorials/build-a-blockchain/build-local-blockchain/

@0xLucca 0xLucca requested a review from nhussein11 September 9, 2024 13:52
github-actions[bot]
github-actions bot reviewed Sep 9, 2024
View reviewed changes
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
@0xLucca @nhussein11
Apply suggestions from code review
56faa24 
Co-authored-by: Nicolás Hussein <[email protected]>
@0xLucca 0xLucca requested a review from dawnkelly09 September 10, 2024 23:04
dawnkelly09
dawnkelly09 requested changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had a chance to run this to make sure it all works by following the steps yet but, I left comments on some formatting, etc. Thank you!

tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
@CrackTheCode016 CrackTheCode016 self-requested a review September 18, 2024 20:13
CrackTheCode016
CrackTheCode016 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine to me content wise!

tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
eshaben
eshaben reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Minor stuff 🙂

Also, please resolve the merge conflicts!

tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/index.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Outdated Show resolved Hide resolved
@0xLucca 0xLucca requested a review from eshaben September 23, 2024 13:02
github-actions[bot]
github-actions bot reviewed Sep 23, 2024
View reviewed changes
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
tutorials/polkadot-sdk/build-a-blockchain/build-a-local-blockchain.md Show resolved Hide resolved
eshaben
eshaben approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dawnkelly09
dawnkelly09 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@eshaben eshaben merged commit 715212d into master Sep 23, 2024
1 check failed
@eshaben eshaben deleted the 0xlucca/psdk-build-a-blockchain branch September 23, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhussein11 nhussein11 nhussein11 left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@CrackTheCode016 CrackTheCode016 CrackTheCode016 approved these changes

@dawnkelly09 dawnkelly09 dawnkelly09 approved these changes

@eshaben eshaben eshaben approved these changes

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xLucca @eshaben @CrackTheCode016 @nhussein11 @dawnkelly09