Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Substrate.io Migration] Tutorials -> Build a Parachain -> Connect a parachain #22

Merged
merged 41 commits into from
Sep 26, 2024

Conversation

nhussein11
Copy link
Collaborator

The "Connect a parachain" page was migrated from the existing Substrate.io Tutorial section: https://docs.substrate.io/tutorials/build-a-parachain/connect-a-local-parachain/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vale

tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|79 col 104| [Papermoon.Acronyms] Spell out 'SCALE', if it's unfamiliar to the audience.
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|84 col 138| [Papermoon.Acronyms] Spell out 'SCALE', if it's unfamiliar to the audience.
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|88 col 301| [Papermoon.CustomDictionary] Did you really mean 'protocolId'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|88 col 301| [Vale.Spelling] Did you really mean 'protocolId'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|93 col 14| [Vale.Terms] Use 'relay chain' instead of 'Relay Chain'.
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|103 col 40| [Vale.Spelling] Did you really mean 'alice'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|103 col 40| [Papermoon.CustomDictionary] Did you really mean 'alice'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|174 col 154| [Vale.Spelling] Did you really mean 'alice'?
tutorials/polkadot-sdk/build-a-parachain/prepare-relay-chain.md|174 col 154| [Papermoon.CustomDictionary] Did you really mean 'alice'?

@0xLucca 0xLucca requested a review from eshaben September 24, 2024 11:39
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the terminal output to snippets. Will need another reviewer to sign off since I made changes.

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this in and fix anything else in PR #28

@eshaben eshaben merged commit 01803d1 into master Sep 26, 2024
@eshaben eshaben deleted the nhussein11/tutorials-substrate-connect-a-parachain branch September 26, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants