Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] - remote snippets #231

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Conversation

nhussein11
Copy link
Collaborator

@nhussein11 nhussein11 commented Dec 4, 2024

This PR aims to:

  • Fix those links to snippets that weren't updated according to the new IA (mainly asset transfer api page)
  • Remove those snippets that can be replaced by a remote source tied to a specific version or tag

Note: I double checked before pushing, but please review this PR carefully since I made many changes that are prone to error

@nhussein11 nhussein11 requested a review from a team as a code owner December 4, 2024 17:31
@nhussein11 nhussein11 requested a review from 0xLucca December 4, 2024 17:33
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just review the PolkadotSDK version in variables.yml

variables.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just thinking maybe we should be enforcing the use of variables more frequently?

@@ -102,7 +102,7 @@ Creates a local XCM transaction to retrieve trapped assets. This function can be


```ts
--8<-- 'code/develop/toolkit/interoperability/asset-transfer-api/reference/ca-fn-signature.ts'
--8<-- 'https://raw.githubusercontent.com/paritytech/asset-transfer-api/refs/tags/v0.3.1/src/AssetTransferApi.ts:344:349'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using a variable for v0.3.1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eshaben I got the following error when trying to do that:

http.client.InvalidURL: URL can't contain control characters. '/paritytech/asset-transfer-api/refs/tags/{{ dependencies.asset_transfer_api.version }}/src/types.ts' (found at least ' ')

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah ok. Thanks for trying!

@nhussein11 nhussein11 removed Pre-Launch HIGH High priority task labels Dec 13, 2024
@nhussein11
Copy link
Collaborator Author

Removing High and Pre-Launch labels, this PR is a nice to have

@nhussein11 nhussein11 force-pushed the nhussein11/fix-remote-snippets branch from 31416ce to fc1ca3d Compare December 16, 2024 14:05
nhussein11 and others added 10 commits December 19, 2024 09:57
* fix: add wip

* fix: adding last sections

* fix: wording

* fix: structure

* Apply suggestions from code review

Co-authored-by: 0xLucca <[email protected]>

* fix: adding links

* fix: images structure

* fix: paraphrasing

* fix: paraphrasing

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: Erin Shaben <[email protected]>

* fix: table

* fix: adding papi tutorial

* fix: paraphrasing

* fix: moving code to snippet

* fix: snippet

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: 0xLucca <[email protected]>

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: 0xLucca <[email protected]>

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: 0xLucca <[email protected]>

* fix: feedback

* fix: snippet

* fix: link

---------

Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
* fix: adding reference to tutorials on asset hub page

* Add xcm channels

* Add runtime upgrades

* Add chain spec

* Add custom parachains

* fix: adding chopsticks

* fix: zombienet

* Update develop/parachains/get-started/build-custom-parachains.md

Co-authored-by: Nicolás Hussein <[email protected]>

* fix: xcm channels references

* fix: generate chain specs references

* fix: generate chain specs 'where to go next'

* fix: build custom parachains references

* fix: runtime upgrades references

* fix: chopsticks get started references

* fix: zombienet get started references

* fix: asset hub references

* fix: add existing pallets references

* fix: add smart contract funcionality references

* fix: make custom pallet references

* fix: pallet testing references

* fix: generate chain specs references

* fix: adding comment in build custom parachains

* fix: deploy parachain to polkadot references

* fix: setup references

* fix: consensus get started references removed

* fix: architecture parachains references

---------

Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: 0xLucca <[email protected]>
…he Pallet (#232)

* wip: build-pallet

* Page ready

* Improvements

* Extract code snippets

* Description and grammarly

* fix: typo

* Add suggestions

* Update tutorials/polkadot-sdk/parachains/build-custom-pallet/build-pallet.md

Co-authored-by: Nicolás Hussein <[email protected]>

* Add root origin reference

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

* Apply fmt

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nicolás Hussein <[email protected]>

* Apply fixes

---------

Co-authored-by: nhussein11 <[email protected]>
Co-authored-by: Nicolás Hussein <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
* Remove get-started section

* Remove build and deploy pages

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

---------

Co-authored-by: Erin Shaben <[email protected]>
…Unit Testing (#233)

* fix: wip

* fix: adding snippets

* fix: typo

* Apply suggestions from code review

Co-authored-by: 0xLucca <[email protected]>

* fix: updating mock runtime\

* fix: snippets comments

* fix: typo

* fix: closing expandable elements

* fix: overflow

* fix: overflow

* Update tutorials/polkadot-sdk/parachains/build-custom-pallet/pallet-unit-testing.md

Co-authored-by: Erin Shaben <[email protected]>

* fix: feedback

* fix: clean up the add tutorial branch

* Update tutorials/polkadot-sdk/parachains/build-custom-pallet/pallet-unit-testing.md

Co-authored-by: Erin Shaben <[email protected]>

---------

Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
CrackTheCode016 and others added 10 commits December 19, 2024 10:11
* updates so far

* Add finishing touches

* comments

* Apply suggestions from code review

Co-authored-by: Nicolás Hussein <[email protected]>

* change to chain-spec-builder

* Update tutorials/polkadot-sdk/parachains/deploy-to-relay-chain/deploy-on-paseo.md

Co-authored-by: Iulian Barbu <[email protected]>

* feedback

* replace parachain-template-node

* fix most instructions

* few things

---------

Co-authored-by: Nicolás Hussein <[email protected]>
Co-authored-by: Iulian Barbu <[email protected]>
* fix: testing refactor

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

* fix: references and snippets

* fix: adding cards

* Apply suggestions from code review

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/mock-runtime.md

Co-authored-by: Dawn Kelly <[email protected]>

* Tutorials > Interoperability > XCM Transfers (#221)

* fix: add wip

* fix: adding last sections

* fix: wording

* fix: structure

* Apply suggestions from code review

Co-authored-by: 0xLucca <[email protected]>

* fix: adding links

* fix: images structure

* fix: paraphrasing

* fix: paraphrasing

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: Erin Shaben <[email protected]>

* fix: table

* fix: adding papi tutorial

* fix: paraphrasing

* fix: moving code to snippet

* fix: snippet

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: 0xLucca <[email protected]>

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: 0xLucca <[email protected]>

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: 0xLucca <[email protected]>

* fix: feedback

* fix: snippet

* fix: link

---------

Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>

* [FIX] - Adding references to tutorials (#230)

* fix: adding reference to tutorials on asset hub page

* Add xcm channels

* Add runtime upgrades

* Add chain spec

* Add custom parachains

* fix: adding chopsticks

* fix: zombienet

* Update develop/parachains/get-started/build-custom-parachains.md

Co-authored-by: Nicolás Hussein <[email protected]>

* fix: xcm channels references

* fix: generate chain specs references

* fix: generate chain specs 'where to go next'

* fix: build custom parachains references

* fix: runtime upgrades references

* fix: chopsticks get started references

* fix: zombienet get started references

* fix: asset hub references

* fix: add existing pallets references

* fix: add smart contract funcionality references

* fix: make custom pallet references

* fix: pallet testing references

* fix: generate chain specs references

* fix: adding comment in build custom parachains

* fix: deploy parachain to polkadot references

* fix: setup references

* fix: consensus get started references removed

* fix: architecture parachains references

---------

Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: 0xLucca <[email protected]>

* Tutorials > Polkadot SDK > Parachains > Build Custom Pallet > Build the Pallet (#232)

* wip: build-pallet

* Page ready

* Improvements

* Extract code snippets

* Description and grammarly

* fix: typo

* Add suggestions

* Update tutorials/polkadot-sdk/parachains/build-custom-pallet/build-pallet.md

Co-authored-by: Nicolás Hussein <[email protected]>

* Add root origin reference

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

* Apply fmt

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nicolás Hussein <[email protected]>

* Apply fixes

---------

Co-authored-by: nhussein11 <[email protected]>
Co-authored-by: Nicolás Hussein <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>

* fix: hidding polkaVM instances and adding informational banner (#251)

* Restructure Get Started section (#246)

* Remove get-started section

* Remove build and deploy pages

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

---------

Co-authored-by: Erin Shaben <[email protected]>

* Tutorials > Polkadot SDK > Parachains > Build Custom Pallet > Pallet Unit Testing (#233)

* fix: wip

* fix: adding snippets

* fix: typo

* Apply suggestions from code review

Co-authored-by: 0xLucca <[email protected]>

* fix: updating mock runtime\

* fix: snippets comments

* fix: typo

* fix: closing expandable elements

* fix: overflow

* fix: overflow

* Update tutorials/polkadot-sdk/parachains/build-custom-pallet/pallet-unit-testing.md

Co-authored-by: Erin Shaben <[email protected]>

* fix: feedback

* fix: clean up the add tutorial branch

* Update tutorials/polkadot-sdk/parachains/build-custom-pallet/pallet-unit-testing.md

Co-authored-by: Erin Shaben <[email protected]>

---------

Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>

* fix: feedback applied on mock runtime desc

* fix: adding further resources

* Update develop/parachains/testing/mock-runtime.md

Co-authored-by: Kian Paimani <[email protected]>

* fix: glossary runtime reference

* fix: paraphrasing according to feedback

* fix: paraphrasing

* corrects "benchmark testing" to "benchmarking" throughout the page

* Apply suggestions from code review

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/benchmarking.md

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/pallet-testing.md

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/pallet-testing.md

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/pallet-testing.md

Co-authored-by: Dawn Kelly <[email protected]>

* fix: adding reference to polkadot sdk guide

* fix: curly aphostrophes

* Update develop/parachains/testing/mock-runtime.md

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/mock-runtime.md

Co-authored-by: Dawn Kelly <[email protected]>

* fix: feedback

* fix: feedback

---------

Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: DAWN KELLY <[email protected]>
* Coretime tutorial (most things)

* grammarly

* change to webp

* Apply suggestions from code review

Co-authored-by: Nicolás Hussein <[email protected]>

* paseo imgs

* ondemand updates

* update

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* fix: note

* fix: removing note

* fix: removing fake reference

---------

Co-authored-by: Nicolás Hussein <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: nhussein11 <[email protected]>
* add pages for legal policies and info

* pull in legal docs from mkdocs

* Apply suggestions from code review

Co-authored-by: albertov19 <[email protected]>

---------

Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: albertov19 <[email protected]>
* removes "crosschain" as a dev pathway from develop/index.md

* save point before adding grid elements

* merges dev-pathways content into dev index page, updates incorrect link to Nova wallet, removes dev-pathways and updates nav

* updates Pathway name to use Application Developers consistently on this page

* adds some info to parachains/index

* update card format on develop/index, adds tip re: smart contracts are in active dev to develop/smart-contracts/index

* update language describing dev paths on develop/toolkit/index for consistency with rest of section

* typo fix

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

---------

Co-authored-by: Erin Shaben <[email protected]>
* Init structure

* wip: set-up-a-template

* Finish set up a template

* [FIX] - Adding references to tutorials (#230)

* fix: adding reference to tutorials on asset hub page

* Add xcm channels

* Add runtime upgrades

* Add chain spec

* Add custom parachains

* fix: adding chopsticks

* fix: zombienet

* Update develop/parachains/get-started/build-custom-parachains.md

Co-authored-by: Nicolás Hussein <[email protected]>

* fix: xcm channels references

* fix: generate chain specs references

* fix: generate chain specs 'where to go next'

* fix: build custom parachains references

* fix: runtime upgrades references

* fix: chopsticks get started references

* fix: zombienet get started references

* fix: asset hub references

* fix: add existing pallets references

* fix: add smart contract funcionality references

* fix: make custom pallet references

* fix: pallet testing references

* fix: generate chain specs references

* fix: adding comment in build custom parachains

* fix: deploy parachain to polkadot references

* fix: setup references

* fix: consensus get started references removed

* fix: architecture parachains references

---------

Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: 0xLucca <[email protected]>

* Tutorials > Polkadot SDK > Parachains > Build Custom Pallet > Build the Pallet (#232)

* wip: build-pallet

* Page ready

* Improvements

* Extract code snippets

* Description and grammarly

* fix: typo

* Add suggestions

* Update tutorials/polkadot-sdk/parachains/build-custom-pallet/build-pallet.md

Co-authored-by: Nicolás Hussein <[email protected]>

* Add root origin reference

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

* Apply fmt

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nicolás Hussein <[email protected]>

* Apply fixes

---------

Co-authored-by: nhussein11 <[email protected]>
Co-authored-by: Nicolás Hussein <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>

* fix: index zero to hero

* fix: clean up .pages

* fix: set up template where to go next

* fix: adding build a custom pallet content and moving code snippets

* Fix build pallet page

* wip: Add pallets to the runtime

* fix: wip

* fix: clean up pallet unit testing

* fix: pre-commit whitelisted files

* Finish add pallet to runtime

* Improve story telling

* wip: Execute Runtime Upgrades

* wip: deploy to testnet

* Deploy to Testnet ready

* Apply suggestions from code review

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/maintenance/runtime-upgrades.md

Co-authored-by: Dawn Kelly <[email protected]>

* Update tutorials/polkadot-sdk/parachains/zero-to-hero/add-pallets-to-runtime.md

Co-authored-by: Dawn Kelly <[email protected]>

* fix: adding tip to zero to hero index page

* [FIX] - Refactoring testing section (#248)

* fix: testing refactor

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

* fix: references and snippets

* fix: adding cards

* Apply suggestions from code review

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/mock-runtime.md

Co-authored-by: Dawn Kelly <[email protected]>

* Tutorials > Interoperability > XCM Transfers (#221)

* fix: add wip

* fix: adding last sections

* fix: wording

* fix: structure

* Apply suggestions from code review

Co-authored-by: 0xLucca <[email protected]>

* fix: adding links

* fix: images structure

* fix: paraphrasing

* fix: paraphrasing

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: Erin Shaben <[email protected]>

* fix: table

* fix: adding papi tutorial

* fix: paraphrasing

* fix: moving code to snippet

* fix: snippet

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: 0xLucca <[email protected]>

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: 0xLucca <[email protected]>

* Update tutorials/interoperability/xcm-transfers/from-relaychain-to-parachain.md

Co-authored-by: 0xLucca <[email protected]>

* fix: feedback

* fix: snippet

* fix: link

---------

Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>

* [FIX] - Adding references to tutorials (#230)

* fix: adding reference to tutorials on asset hub page

* Add xcm channels

* Add runtime upgrades

* Add chain spec

* Add custom parachains

* fix: adding chopsticks

* fix: zombienet

* Update develop/parachains/get-started/build-custom-parachains.md

Co-authored-by: Nicolás Hussein <[email protected]>

* fix: xcm channels references

* fix: generate chain specs references

* fix: generate chain specs 'where to go next'

* fix: build custom parachains references

* fix: runtime upgrades references

* fix: chopsticks get started references

* fix: zombienet get started references

* fix: asset hub references

* fix: add existing pallets references

* fix: add smart contract funcionality references

* fix: make custom pallet references

* fix: pallet testing references

* fix: generate chain specs references

* fix: adding comment in build custom parachains

* fix: deploy parachain to polkadot references

* fix: setup references

* fix: consensus get started references removed

* fix: architecture parachains references

---------

Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: 0xLucca <[email protected]>

* Tutorials > Polkadot SDK > Parachains > Build Custom Pallet > Build the Pallet (#232)

* wip: build-pallet

* Page ready

* Improvements

* Extract code snippets

* Description and grammarly

* fix: typo

* Add suggestions

* Update tutorials/polkadot-sdk/parachains/build-custom-pallet/build-pallet.md

Co-authored-by: Nicolás Hussein <[email protected]>

* Add root origin reference

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

* Apply fmt

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nicolás Hussein <[email protected]>

* Apply fixes

---------

Co-authored-by: nhussein11 <[email protected]>
Co-authored-by: Nicolás Hussein <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>

* fix: hidding polkaVM instances and adding informational banner (#251)

* Restructure Get Started section (#246)

* Remove get-started section

* Remove build and deploy pages

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

---------

Co-authored-by: Erin Shaben <[email protected]>

* Tutorials > Polkadot SDK > Parachains > Build Custom Pallet > Pallet Unit Testing (#233)

* fix: wip

* fix: adding snippets

* fix: typo

* Apply suggestions from code review

Co-authored-by: 0xLucca <[email protected]>

* fix: updating mock runtime\

* fix: snippets comments

* fix: typo

* fix: closing expandable elements

* fix: overflow

* fix: overflow

* Update tutorials/polkadot-sdk/parachains/build-custom-pallet/pallet-unit-testing.md

Co-authored-by: Erin Shaben <[email protected]>

* fix: feedback

* fix: clean up the add tutorial branch

* Update tutorials/polkadot-sdk/parachains/build-custom-pallet/pallet-unit-testing.md

Co-authored-by: Erin Shaben <[email protected]>

---------

Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>

* fix: feedback applied on mock runtime desc

* fix: adding further resources

* Update develop/parachains/testing/mock-runtime.md

Co-authored-by: Kian Paimani <[email protected]>

* fix: glossary runtime reference

* fix: paraphrasing according to feedback

* fix: paraphrasing

* corrects "benchmark testing" to "benchmarking" throughout the page

* Apply suggestions from code review

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/benchmarking.md

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/pallet-testing.md

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/pallet-testing.md

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/pallet-testing.md

Co-authored-by: Dawn Kelly <[email protected]>

* fix: adding reference to polkadot sdk guide

* fix: curly aphostrophes

* Update develop/parachains/testing/mock-runtime.md

Co-authored-by: Dawn Kelly <[email protected]>

* Update develop/parachains/testing/mock-runtime.md

Co-authored-by: Dawn Kelly <[email protected]>

* fix: feedback

* fix: feedback

---------

Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: DAWN KELLY <[email protected]>

* fix: typo (#258)

* Obtain Coretime Tutorial (#250)

* Coretime tutorial (most things)

* grammarly

* change to webp

* Apply suggestions from code review

Co-authored-by: Nicolás Hussein <[email protected]>

* paseo imgs

* ondemand updates

* update

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* Update tutorials/polkadot-sdk/parachains/obtain-coretime.md

Co-authored-by: Erin Shaben <[email protected]>

* fix: note

* fix: removing note

* fix: removing fake reference

---------

Co-authored-by: Nicolás Hussein <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: nhussein11 <[email protected]>

* fix: updating coretime page, images and snippet according to the zero-to-hero structure

* fix: coretime desc

* fix: todos

* fix: where to go next

* updates to some index pages

* fix: where to go next (2)

* Remove old content

* Apply suggestions from code review

Co-authored-by: Erin Shaben <[email protected]>

* Remove execute-runtime-upgrade tutorial

* fix: adding links to prev tutorials

* fix: adding reference to utility pallet

* Update index file

* fix: adding link to zero to hero index

* Update build pallet name

* fix: polkadot sdk tutorials index

* Comment where to go next section in develop

* Update develop/parachains/maintenance/runtime-upgrades.md

Co-authored-by: Erin Shaben <[email protected]>

* fix: CTAs

* fix: CTAs titles to generic "Get Started"

* Update tutorials section index file

* fix: card style

* removes coming soon content, adds Where to Go Next to Install Polkadot SDK page to link to Zero to Hero section

* few updates to links

* update prereq copy on set up a template

* updates link

* update link text

---------

Co-authored-by: Nicolás Hussein <[email protected]>
Co-authored-by: nhussein11 <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: DAWN KELLY <[email protected]>
Co-authored-by: bader y <[email protected]>
@nhussein11 nhussein11 requested a review from eshaben December 19, 2024 13:15
@@ -238,7 +246,7 @@ Fetch estimated fee information for an extrinsic.
}
```

For more information on the underlying types and fields of `RuntimeDispatchInfo`, check the [RuntimeDispatchInfo](https://github.com/polkadot-js/api/blob/2329af239eaf194696daeaa58ebf89f0080a5e0d/packages/types/src/interfaces/payment/types.ts#L21){target=\_blank} source code.
For more information on the underlying types and fields of `RuntimeDispatchInfo`, check the [RuntimeDispatchInfo](https://github.com/polkadot-js/api/blob/v15.0.2/packages/types/src/interfaces/payment/types.ts#L21){target=\_blank} source code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more information on the underlying types and fields of `RuntimeDispatchInfo`, check the [RuntimeDispatchInfo](https://github.com/polkadot-js/api/blob/v15.0.2/packages/types/src/interfaces/payment/types.ts#L21){target=\_blank} source code.
For more information on the underlying types and fields of `RuntimeDispatchInfo`, check the [`RuntimeDispatchInfo`](https://github.com/polkadot-js/api/blob/v15.0.2/packages/types/src/interfaces/payment/types.ts#L21){target=\_blank} source code.

@@ -251,7 +259,7 @@ Fetch estimated fee information for an extrinsic.
}
```

For more information on the underlying types and fields of `RuntimeDispatchInfoV1`, check the [RuntimeDispatchInfoV1](https://github.com/polkadot-js/api/blob/2329af239eaf194696daeaa58ebf89f0080a5e0d/packages/types/src/interfaces/payment/types.ts#L28){target=\_blank} source code.
For more information on the underlying types and fields of `RuntimeDispatchInfoV1`, check the [RuntimeDispatchInfoV1](https://github.com/polkadot-js/api/blob/v15.0.2/packages/types/src/interfaces/payment/types.ts#L28){target=\_blank} source code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For more information on the underlying types and fields of `RuntimeDispatchInfoV1`, check the [RuntimeDispatchInfoV1](https://github.com/polkadot-js/api/blob/v15.0.2/packages/types/src/interfaces/payment/types.ts#L28){target=\_blank} source code.
For more information on the underlying types and fields of `RuntimeDispatchInfoV1`, check the [`RuntimeDispatchInfoV1`](https://github.com/polkadot-js/api/blob/v15.0.2/packages/types/src/interfaces/payment/types.ts#L28){target=\_blank} source code.

@@ -9,7 +9,7 @@ description: A guide detailing the step-by-step process of converting assets on

Asset Conversion is an Automated Market Maker (AMM) utilizing [Uniswap V2](https://github.com/Uniswap/v2-core){target=\_blank} logic and implemented as a pallet on Polkadot's Asset Hub. For more details about this feature, please visit the [Asset Conversion on Asset Hub](https://wiki.polkadot.network/docs/learn-asset-conversion-assethub){target=\_blank} wiki page.

This guide will provide detailed information about the key functionalities offered by the [Asset Conversion](https://github.com/paritytech/polkadot-sdk/tree/master/substrate/frame/asset-conversion){target=\_blank} pallet on Asset Hub, including:
This guide will provide detailed information about the key functionalities offered by the [Asset Conversion](https://github.com/paritytech/polkadot-sdk/tree/polkadot-stable2412/substrate/frame/asset-conversion){target=\_blank} pallet on Asset Hub, including:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use variables in link text, so all these links should be updated. For example this one should be:

Suggested change
This guide will provide detailed information about the key functionalities offered by the [Asset Conversion](https://github.com/paritytech/polkadot-sdk/tree/polkadot-stable2412/substrate/frame/asset-conversion){target=\_blank} pallet on Asset Hub, including:
This guide will provide detailed information about the key functionalities offered by the [Asset Conversion](https://github.com/paritytech/polkadot-sdk/tree/{{dependencies.polkadot_sdk.stable_version}}/substrate/frame/asset-conversion){target=\_blank} pallet on Asset Hub, including:

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay in getting back to you on this one! I think some of these links just need to be revisited, not the snippet ones as I saw your comment on those, but just normal links.

Saw some polkadot-js github references, so lets create a variable for that and use the variable in the links pointing to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants