Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document "Connect your wallet" for asset hub smart contracts #300

Open
wants to merge 23 commits into
base: staging-ah-smart-contracts
Choose a base branch
from
Open

Document "Connect your wallet" for asset hub smart contracts #300

wants to merge 23 commits into from

Conversation

nhussein11
Copy link
Collaborator

@nhussein11 nhussein11 commented Jan 7, 2025 •
edited
Loading

This PR aims to add a basic documentation of how to connect your wallet to asset hub smart contracts

Note: The IA used is preliminary. We can circle back on this later on and define where all this content should be located

@nhussein11 nhussein11 requested a review from a team as a code owner January 7, 2025 14:16
@nhussein11 nhussein11 linked an issue Jan 7, 2025 that may be closed by this pull request
Document how to connect Metamask to Westend AssetHub #277
Open
@nhussein11 nhussein11 changed the title Document Connect your wallet for asset hub smart contracts Document "Connect your wallet" for asset hub smart contracts Jan 7, 2025
@nhussein11 nhussein11 changed the base branch from master to staging-ah-smart-contracts January 7, 2025 15:29
CrackTheCode016
CrackTheCode016 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

develop/smart-contracts/evm/connect-your-wallet.md Outdated Show resolved Hide resolved
develop/smart-contracts/evm/connect-your-wallet.md Outdated Show resolved Hide resolved
develop/smart-contracts/evm/connect-your-wallet.md Outdated Show resolved Hide resolved
develop/smart-contracts/evm/connect-your-wallet.md Outdated

To get started with Metamask, you need to install the [MetaMask extension](https://metamask.io/download/){target=\_blank} and add it to the browser. Once, you have metamask installed, you can set up a new wallet and securely store your seed phrase. This phrase is crucial for recovery in case you lose access.

## Connect to the Asset Hub Westend Testnet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be a button / embed we could put here too, see: https://contracts.polkadot.io/connect-to-asset-hub/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the https://contracts.polkadot.io/connect-to-asset-hub/ was a temporary solution until this documentation is ready. If not, we can add the link at the end of this page to connect to contracts.polkadot.io. Do you know if that is the case?

develop/smart-contracts/evm/connect-your-wallet.md Outdated Show resolved Hide resolved
develop/smart-contracts/evm/connect-your-wallet.md Outdated Show resolved Hide resolved
develop/smart-contracts/evm/connect-your-wallet.md Outdated Show resolved Hide resolved
@nhussein11 nhussein11 requested a review from a team January 7, 2025 17:39
kianenigma
kianenigma reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course the content here is okay, but I am having a hard time approving it, as I don't know where it sits in the IA.

@nhussein11
Copy link
Collaborator Author

nhussein11 commented Jan 8, 2025 •
edited
Loading

Of course the content here is okay, but I am having a hard time approving it, as I don't know where it sits in the IA.

Thanks, this page will be merged into staging-ah-smart-contracts, which is a branch containing the initial IA where we intended to place this content.

For this particular page, the path would be: /develop/smart-contracts/evm-toolkit/connect-your-wallet.md

@nhussein11 nhussein11 added the B0 - Needs Review Pull request is ready for review label Jan 9, 2025
@eshaben eshaben added C1 - Medium Medium priority task A0 - New Content Pull request contains new content pages labels Jan 13, 2025
0xLucca
0xLucca reviewed Jan 14, 2025
View reviewed changes
develop/smart-contracts/evm-toolkit/connect-your-wallet.md Outdated Show resolved Hide resolved
develop/smart-contracts/evm-toolkit/connect-your-wallet.md Outdated

1. Open the MetaMask extension and click in the network icon to switch to the Asset Hub Westend TestNet

![](/images/develop/smart-contracts/evm-toolkit/connect-your-wallet/connect-your-wallet-1.webp)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to center these images?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible. Maybe the @polkadot-developers/docs-formatting-team could lend us a hand with this

develop/smart-contracts/evm-toolkit/connect-your-wallet.md Show resolved Hide resolved
develop/smart-contracts/evm-toolkit/connect-your-wallet.md Outdated Show resolved Hide resolved
@0xLucca 0xLucca self-requested a review January 14, 2025 14:47
0xLucca
0xLucca approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kianenigma
Copy link
Contributor

Of course the content here is okay, but I am having a hard time approving it, as I don't know where it sits in the IA.

Thanks, this page will be merged into staging-ah-smart-contracts, which is a branch containing the initial IA where we intended to place this content.

For this particular page, the path would be: /develop/smart-contracts/evm-toolkit/connect-your-wallet.md

Okay, please keep in mind that this IA is something that is super important and should not be one person's opinion. Can you share any proposed IA to our TG chat so we can discuss it there?

@albertov19
Copy link
Collaborator

Of course the content here is okay, but I am having a hard time approving it, as I don't know where it sits in the IA.

Thanks, this page will be merged into staging-ah-smart-contracts, which is a branch containing the initial IA where we intended to place this content.
For this particular page, the path would be: /develop/smart-contracts/evm-toolkit/connect-your-wallet.md

Okay, please keep in mind that this IA is something that is super important and should not be one person's opinion. Can you share any proposed IA to our TG chat so we can discuss it there?

Kian note that this is all being merged into a staging branch so that we can start moving forward with some stuff that we can later easily revisit. But we need to have something in place so that we can start creating content because the deadline is approaching etc

dawnkelly09
dawnkelly09 requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small changes requested. Page looks nice though!

develop/smart-contracts/evm-toolkit/connect-your-wallet.md Outdated Show resolved Hide resolved
develop/smart-contracts/evm-toolkit/connect-your-wallet.md Outdated Show resolved Hide resolved
develop/smart-contracts/evm-toolkit/connect-your-wallet.md Outdated Show resolved Hide resolved
develop/smart-contracts/evm-toolkit/connect-your-wallet.md Outdated Show resolved Hide resolved
@nhussein11 nhussein11 mentioned this pull request Jan 20, 2025
Open
dawnkelly09
dawnkelly09 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thank you!!

@dawnkelly09 dawnkelly09 added B1 - Ready to be Merged Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Jan 22, 2025
@dawnkelly09
Copy link
Collaborator

Sorry about the revert! Committed a change to the wrong branch :-)

@nhussein11 nhussein11 requested a review from eshaben January 23, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xlukem 0xlukem 0xlukem left review comments

@kianenigma kianenigma kianenigma left review comments

@0xLucca 0xLucca 0xLucca approved these changes

@dawnkelly09 dawnkelly09 dawnkelly09 approved these changes

@CrackTheCode016 CrackTheCode016 CrackTheCode016 approved these changes

@eshaben eshaben Awaiting requested review from eshaben

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
A0 - New Content Pull request contains new content pages B1 - Ready to be Merged Pull request is ready to be merged C1 - Medium Medium priority task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to connect Metamask to Westend AssetHub
8 participants
@nhussein11 @kianenigma @albertov19 @dawnkelly09 @eshaben @CrackTheCode016 @0xLucca @0xlukem