Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Polkadot WIki Migration] Set up a RPC node #32

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

CrackTheCode016
Copy link
Collaborator

infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
@dawnkelly09
Copy link
Collaborator

Scan for Vale false positives. Resolved convos = made it on the update list and should go away now. I left comments for the legit flags with suggested edits. Thank you!

infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
@dawnkelly09
Copy link
Collaborator

Alrighty, made a bunch of edits. Need a new content review from @0xLucca (especially pruned nodes part as I Googled it!) and format review from @eshaben

@dawnkelly09 dawnkelly09 requested review from eshaben and removed request for dawnkelly09 October 2, 2024 19:24
0xLucca
0xLucca previously approved these changes Oct 2, 2024
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine. Just check the last comment I left

infrastructure/general/setup-rpc.md Show resolved Hide resolved
infrastructure/general/.pages Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
infrastructure/general/setup-rpc.md Outdated Show resolved Hide resolved
@dawnkelly09
Copy link
Collaborator

dawnkelly09 commented Oct 7, 2024

This should be good to go. Tech review was dismissed as stale so we'll need one tech and one format to merge. Thanks!

Copy link
Collaborator

@nhussein11 nhussein11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dawnkelly09 dawnkelly09 merged commit 8273441 into master Oct 7, 2024
@dawnkelly09 dawnkelly09 deleted the bd-infra-setup-rpc-node branch October 7, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants