Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Polkadot Wiki Migration] Offenses and Slashes #43

Merged
merged 13 commits into from
Nov 15, 2024

Conversation

CrackTheCode016
Copy link
Collaborator

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vale

infrastructure/validators/offenses-slashes.md|112 col 62| [Vale.Spelling] Did you really mean 'unapplied'?
infrastructure/validators/offenses-slashes.md|112 col 62| [Papermoon.CustomDictionary] Did you really mean 'unapplied'?
infrastructure/validators/offenses-slashes.md|116 col 1| [Papermoon.CustomDictionary] Did you really mean 'unapplied'?
infrastructure/validators/offenses-slashes.md|116 col 1| [Vale.Spelling] Did you really mean 'unapplied'?
infrastructure/validators/offenses-slashes.md|130 col 19| [Papermoon.NotContractions] Use 'aren't' instead of 'are not'.
infrastructure/validators/offenses-slashes.md|130 col 79| [Google.Semicolons] Use semicolons judiciously.
infrastructure/validators/offenses-slashes.md|134 col 54| [Papermoon.NotContractions] Use 'don't' instead of 'do not'.
infrastructure/validators/offenses-slashes.md|142 col 23| [Google.Latin] Use 'that is' instead of 'i.e.'.
infrastructure/validators/offenses-slashes.md|146 col 82| [Papermoon.NotContractions] Use 'aren't' instead of 'are not'.
infrastructure/validators/offenses-slashes.md|150 col 67| [Papermoon.CustomDictionary] Did you really mean 'reputational'?
infrastructure/validators/offenses-slashes.md|150 col 67| [Vale.Spelling] Did you really mean 'reputational'?
infrastructure/validators/offenses-slashes.md|153 col 53| [Vale.Avoid] Avoid using 'our'.
infrastructure/validators/offenses-slashes.md|153 col 53| [Google.We] Try to avoid using first-person plural like 'our'.
infrastructure/validators/offenses-slashes.md|158 col 10| [Papermoon.Acronyms] Spell out 'BABE', if it's unfamiliar to the audience.
infrastructure/validators/offenses-slashes.md|158 col 20| [Papermoon.Acronyms] Spell out 'BEEFY', if it's unfamiliar to the audience.
infrastructure/validators/offenses-slashes.md|165 col 6| [Vale.Avoid] Avoid using 'our'.
infrastructure/validators/offenses-slashes.md|165 col 6| [Google.We] Try to avoid using first-person plural like 'our'.
infrastructure/validators/offenses-slashes.md|165 col 23| [Papermoon.NotContractions] Use 'doesn't' instead of 'does not'.
infrastructure/validators/offenses-slashes.md|165 col 56| [Papermoon.Acronyms] Spell out 'BABE', if it's unfamiliar to the audience.
infrastructure/validators/offenses-slashes.md|168 col 12| [Google.Latin] Use 'that is' instead of 'i.e.'.
infrastructure/validators/offenses-slashes.md|176 col 13| [Papermoon.WordSwapList] Use 'preceding' instead of 'above'.
infrastructure/validators/offenses-slashes.md|179 col 25| [Papermoon.NotContractions] Use 'doesn't' instead of 'does not'.
infrastructure/validators/offenses-slashes.md|182 col 1| [Vale.Terms] Use 'validators' instead of 'Validators'.
infrastructure/validators/offenses-slashes.md|184 col 38| [Papermoon.NotContractions] Use 'don't' instead of 'do not'.
infrastructure/validators/offenses-slashes.md|203 col 376| [Papermoon.NotContractions] Use 'didn't' instead of 'did not'.
infrastructure/validators/offenses-slashes.md|205 col 467| [Papermoon.NotContractions] Use 'wasn't' instead of 'was not'.
infrastructure/validators/offenses-slashes.md|213 col 3| [Papermoon.NotContractions] Use 'doesn't' instead of 'does not'.
infrastructure/validators/offenses-slashes.md|214 col 3| [Vale.Spelling] Did you really mean 'Slashable'?
infrastructure/validators/offenses-slashes.md|214 col 3| [Papermoon.CustomDictionary] Did you really mean 'Slashable'?
infrastructure/validators/offenses-slashes.md|217 col 58| [Papermoon.CustomDictionary] Did you really mean 'overslashing'?
infrastructure/validators/offenses-slashes.md|217 col 58| [Vale.Spelling] Did you really mean 'overslashing'?
infrastructure/validators/offenses-slashes.md|235 col 97| [Google.We] Try to avoid using first-person plural like 'our'.
infrastructure/validators/offenses-slashes.md|235 col 97| [Vale.Avoid] Avoid using 'our'.
infrastructure/validators/offenses-slashes.md|236 col 81| [Google.Semicolons] Use semicolons judiciously.
infrastructure/validators/offenses-slashes.md|236 col 99| [Google.We] Try to avoid using first-person plural like 'us'.

infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
@CrackTheCode016 CrackTheCode016 added B0 - Needs Review Pull request is ready for review and removed In Progress labels Sep 20, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

vale

infrastructure/validators/offenses-slashes.md|227 col 81| [Google.Semicolons] Use semicolons judiciously.
infrastructure/validators/offenses-slashes.md|227 col 99| [Google.We] Try to avoid using first-person plural like 'us'.

infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
@eshaben eshaben requested a review from a team October 4, 2024 02:26
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
infrastructure/validators/offenses-slashes.md Outdated Show resolved Hide resolved
@dawnkelly09 dawnkelly09 requested a review from eshaben November 11, 2024 19:23
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagrams look great! I did a spot-check with Grammarly and noticed some things that weren't caught before

infrastructure/staking-mechanics/offenses-and-slashes.md Outdated Show resolved Hide resolved
infrastructure/staking-mechanics/offenses-and-slashes.md Outdated Show resolved Hide resolved
infrastructure/staking-mechanics/offenses-and-slashes.md Outdated Show resolved Hide resolved
infrastructure/staking-mechanics/offenses-and-slashes.md Outdated Show resolved Hide resolved
infrastructure/staking-mechanics/offenses-and-slashes.md Outdated Show resolved Hide resolved
infrastructure/staking-mechanics/offenses-and-slashes.md Outdated Show resolved Hide resolved
infrastructure/staking-mechanics/offenses-and-slashes.md Outdated Show resolved Hide resolved
infrastructure/staking-mechanics/offenses-and-slashes.md Outdated Show resolved Hide resolved
infrastructure/staking-mechanics/offenses-and-slashes.md Outdated Show resolved Hide resolved
infrastructure/staking-mechanics/offenses-and-slashes.md Outdated Show resolved Hide resolved
@dawnkelly09 dawnkelly09 requested a review from eshaben November 14, 2024 16:59
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I asked about disable vs deactivate, but I don't want to hold up the PR based on that, so we can circle back to it later if need be

@eshaben eshaben requested a review from a team November 14, 2024 19:27
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@0xLucca 0xLucca merged commit 194dc9c into master Nov 15, 2024
@0xLucca 0xLucca deleted the bd-infra-offenses-slashes branch November 15, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0 - Needs Review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants