-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new chain #11281
add new chain #11281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the exact same as the other Xcavate chain, just with a different ParaId?
Only name of the chain is same but with different Para_Id and chain has different configuration |
@TarikGul Can you please merge this 🙏? |
This seems like code smell. Vague title - no description - exact same configs but different para_ids. The UI will show |
I have added changes, can you please review and let me know if still not applicable? @TarikGul |
Poor title, and still no description. |
You mean project description? |
Hi @ganesh1997oli, Please ensure that PR include:
This helps in better understanding and reviewing the changes efficiently. You can refer to the following sample PRs for guidance:
Maintaining good PR hygiene improves collaboration and streamlines the review process. Thanks for your cooperation! 🚀 CC: @TarikGul |
Can I close this PR and update para_id of already existing which you guys have been merged without any issue? |
No description provided.