Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new chain #11281

Closed
Closed

Conversation

ganesh1997oli
Copy link
Contributor

No description provided.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the exact same as the other Xcavate chain, just with a different ParaId?

@ganesh1997oli
Copy link
Contributor Author

Isn't this the exact same as the other Xcavate chain, just with a different ParaId?

Only name of the chain is same but with different Para_Id and chain has different configuration

@ganesh1997oli
Copy link
Contributor Author

@TarikGul Can you please merge this 🙏?

@TarikGul
Copy link
Member

This seems like code smell. Vague title - no description - exact same configs but different para_ids. The UI will show Xcavate twice - how will users know which one to pick, and so on.

@ganesh1997oli
Copy link
Contributor Author

ganesh1997oli commented Feb 13, 2025

This seems like code smell. Vague title - no description - exact same configs but different para_ids. The UI will show Xcavate twice - how will users know which one to pick, and so on.

I have added changes, can you please review and let me know if still not applicable? @TarikGul

@TarikGul
Copy link
Member

Poor title, and still no description.

@ganesh1997oli
Copy link
Contributor Author

ganesh1997oli commented Feb 17, 2025

Poor title, and still no description.

You mean project description?
The project is the side project of Xcavate: https://realxdeal.xcavate.io/

@ap211unitech
Copy link
Contributor

Hi @ganesh1997oli,

Please ensure that PR include:

  • A clear and descriptive title
  • A brief yet informative description

This helps in better understanding and reviewing the changes efficiently. You can refer to the following sample PRs for guidance:

Maintaining good PR hygiene improves collaboration and streamlines the review process.

Thanks for your cooperation! 🚀

CC: @TarikGul

@ganesh1997oli
Copy link
Contributor Author

ganesh1997oli commented Feb 18, 2025

Hi @ganesh1997oli,

Please ensure that PR include:

  • A clear and descriptive title
  • A brief yet informative description

This helps in better understanding and reviewing the changes efficiently. You can refer to the following sample PRs for guidance:

Maintaining good PR hygiene improves collaboration and streamlines the review process.

Thanks for your cooperation! 🚀

CC: @TarikGul

Can I close this PR and update para_id of already existing which you guys have been merged without any issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants