-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create simple fuzz tests for CBOR #24
base: master
Are you sure you want to change the base?
Conversation
I've fixed a TODO that was causing the fuzzer to fail most frequently (no range checks for int conversion) but I am unsure how to add tests for it. Example crashing input |
created in about 10 min of fuzzing Coverage of this corpus can be seen here: https://ipfs.io/ipfs/QmaN4dfViSRD4HYX6KZ7yJfwCNtX1hahtS9C9inMgA3oED/coverage.html#file7
WIth the 2e9ba99 fuzzer could not find any more crashers. |
This is super awesome. I can't wait to merge these fixes as well as the fuzzing! I'm a doof for not seeing this in the PR queue earlier, and now I've concurrently forged ahead on... big testing refactors, coincidentally :) And that's now made merge conflicts. But I made 'em; so, I'll try to resolve 'em myself too. Hopefully I'll try to get to this this weekend! Thanks for the PR! |
Cherry-picking out of #24 because I still haven't figured out how to integrate those fuzz test corpuses, but this patch certainly shouldn't wait :)
To run them:
I have fuzzed it for a bit (and nudged go-fuzz to export valid coverage report).
You can see the results here: https://ipfs.io/ipfs/QmaN4dfViSRD4HYX6KZ7yJfwCNtX1hahtS9C9inMgA3oED/coverage.html#file7