Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contains MiniWallet Contracts refactor, MiniServer, Proxy Upgrade Deploys and NFT Scaffolding #11

Closed
wants to merge 1 commit into from
Closed

Contains MiniWallet Contracts refactor, MiniServer, Proxy Upgrade Deploys and NFT Scaffolding #11

wants to merge 1 commit into from

Conversation

johnwhitton
Copy link
Collaborator

This branch is being used to work on Minting NFT for users when registering #10

@johnwhitton johnwhitton changed the title Nft contracts Contains MiniWallet Contracts refactor, MiniServer, Proxy Upgrade Deploys and NFT Scaffolding Sep 1, 2022
@johnwhitton johnwhitton mentioned this pull request Sep 1, 2022
Open
4 tasks
@polymorpher polymorpher changed the base branch from main to miniwallet September 2, 2022 22:28
@polymorpher polymorpher changed the base branch from miniwallet to proxyUpgrade September 2, 2022 22:30
polymorpher
polymorpher reviewed Sep 2, 2022
View reviewed changes
miniwallet/contracts/nft/Mini721.sol
emit SetBaseUri(baseUri);
}

function mintForCommunity(address _to, uint256 _numberOfTokens)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a batch version of this, or have a separate multi-call contract. I recall it wasn't a nice experience using this for thousands of airdrops

polymorpher
polymorpher reviewed Sep 3, 2022
View reviewed changes
Copy link
Owner

@polymorpher polymorpher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good aside from minor cosmetic and syntactical changes

@johnwhitton
Copy link
Collaborator Author

Outstanding Items

  • Multi-call MintForCommunity
  • Deployment Scripts
  • Update NFT UI to use deployed contracts as DUMMY_TOKENS
  • Registration WorkFlow

@johnwhitton
Copy link
Collaborator Author

Closing this PR will progress under PR #14
Items are being tracked under #13

@johnwhitton johnwhitton closed this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polymorpher polymorpher polymorpher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnwhitton @polymorpher