Fix some gateway deserialization errors #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spacebar servers have mention_count in ReadStateEntry as nullable, as well as not having the flags field This should probably be investigated further Reported by greysilly7 on the polyphony discord
Adds a public type which allows serializing one snowflake or an array of snowflakes. Useful for e.g. request guild members, where we can request either for one user or for multiple
Updates the RequsetGuildMembers gateway event, allows to query multiple user_ids and guild_ids using OneOrMoreSnowflakes type, update its documentation
See also #578 on why we aren't currently juts implementing them as types
thanks to MaddyUnderStars; this explanation seems to make sense considering we only need to know if we are ahead / behind the version, not when exactly it was accessed
kozabrada123
commented
Nov 21, 2024
|
It's worth noting that the tests pass locally for me, and it seems our CI is broken again |
kozabrada123
added
Type: Bug
Module: Gateway
Type: New gateway event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commits;
Opcodeenum instead of constants (4ed68ce)presencesinGuildMembersChunkbeing an array, not a single value (4baecf9)activitiesinPresenceUpdateas an empty array when they are sent asnull(1b20102)OneOrMoreSnowflakes, allowGatewayRequestGuildMembersto request multiple guild and user ids (644d3be, 85e922b)LazyRequest(op 14) to use theSnowflaketype for ids instead of justString(61ac7d1)last_viewedinReadStatebeing a version / counter, not aDateTime(fb94afa)