Guild routes #593
Draft
Guild routes #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updates Guild::get, Guild::create, Guild::modify, Guild::get_preview - adds Guild::modify_mfa_level
kozabrada123
added
Type: Bug
Type: Enhancement
- renames Guild::search_members to Guild::query_members, since that's another, different route - updates Guild::get_members and Guild::query_members
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This is a mess
This api is pretty bad to translate to a strong typed language, if I get a better idea I may revisit it Generics don't work, since you need the annotation for chrono::DateTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #43
Additions
Guild::modify_mfa_levelGuild::search_members- this API is not greatGuild::get_members_supplementalChanges
Guild::get- addwith_countsGuild::create- update schema for new fields, see POST /guilds/ schema is outdated spacebarchat/server#1251Guild::modify- update schema, addaudit_log_reasonGuild::get_members- update query parameters, apply them properly, documentation updatesGuild::search_memberstoGuild::query_members, since search members is another different routeGuild::query_members- update query parameters, apply them properly, documentation updatesFixes
Guild::get_preview- method is GET, not PATCH