Skip to content

Commit

Permalink
Fixed Audio Unit name collision
Browse files Browse the repository at this point in the history
- use Jamba 7.1.4 which fixes the class name collision
- changed the audio manufacturer to be Psft since it is supposed to be the same across manufacturers
  • Loading branch information
ypujante committed Dec 9, 2024
1 parent 2c47410 commit b2f58d7
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ include("${JAMBA_ROOT_DIR}/cmake/JambaSetArchitecture.cmake")

set(PLUGIN_MAJOR_VERSION 1)
set(PLUGIN_MINOR_VERSION 6)
set(PLUGIN_PATCH_VERSION 0)
set(PLUGIN_PATCH_VERSION 1)
set(PLUGIN_VERSION "${PLUGIN_MAJOR_VERSION}.${PLUGIN_MINOR_VERSION}.${PLUGIN_PATCH_VERSION}")

project("vst-sam-spl-64" VERSION "${PLUGIN_VERSION}")
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ Check the [SAM-SPL 64](https://pongasoft.com/vst/SAM-SPL64.html) documentation f

Release Notes
-------------
### 2024-12-09 - `v1.6.1`
* Fixed Audio Unit name collision

### 2024-11-28 - `v1.6.0`
* Fixed a crash when exporting the sample
* Migrated to Jamba 7.1.2 / VST SDK 3.7.12
Expand Down
4 changes: 2 additions & 2 deletions audio-unit/audiounitconfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@
/* A manufacturer code for the audio unit, such as Aaud. This value must be exactly 4 alphanumeric characters.
* This value should be unique across audio units of the same manufacturer
* Manufacturer OSType should have at least one non-lower case character */
#define kAUPluginManufacturer Ss64
#define kAUPluginManufacturer Psft

// Definitions for the resource file
#define kAudioUnitName "pongasoft: Sam-Spl 64" // same as kAUPluginName
#define kAudioUnitDescription "Sam-Spl 64" // same as kAUPluginDescription
#define kAudioUnitType 'aumu' // same as kAUPluginType
#define kAudioUnitComponentSubType 'unkw' // same as kAUPluginSubType
#define kAudioUnitComponentManuf 'Ss64' // same as kAUPluginManufacturer
#define kAudioUnitComponentManuf 'Psft' // same as kAUPluginManufacturer

#define kAudioUnitCarbonView 1 // if 0 no Carbon view support will be added
4 changes: 2 additions & 2 deletions fetch_jamba.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ include(FetchContent)

set(JAMBA_GIT_REPO "https://github.com/pongasoft/jamba" CACHE STRING "Jamba git repository url")
set(JAMBA_GIT_TAG v7.1.3 CACHE STRING "Jamba git tag")
set(JAMBA_DOWNLOAD_URL "${JAMBA_GIT_REPO}/archive/refs/tags/v7.1.3.zip" CACHE STRING "Jamba download url")
set(JAMBA_DOWNLOAD_URL_HASH "SHA256=c177c031afebf97e3c8ccaf70e9de09a1cfbe4d4503e45106612cceef03f3fe0" CACHE STRING "Jamba download url hash")
set(JAMBA_DOWNLOAD_URL "${JAMBA_GIT_REPO}/archive/refs/tags/v7.1.4.zip" CACHE STRING "Jamba download url")
set(JAMBA_DOWNLOAD_URL_HASH "SHA256=015a2e1b18f118f23673b995530407b7f47924a06969766451a43af7011917c8" CACHE STRING "Jamba download url hash")

if(JAMBA_ROOT_DIR)
message(STATUS "Using jamba from local ${JAMBA_ROOT_DIR}")
Expand Down

0 comments on commit b2f58d7

Please sign in to comment.