feat: Navigate by typing file/directory names #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to jump to a file or directory by typing the first letters of its display name. Navigation will jump to the next matching item based on the current selection. The same character can also be typed in quick succession to cycle through all items beginning with the same character.
The typed word is reset when no letter has been typed for longer than defined in
PrefixSearch::reset_delay. Currently this value is hard coded to 500ms, but could be easily made configurable. I did not do so yet, since this involves adding another PR for the settings and I wanted to get feedback for this one first.