Update libcosmic #149
Draft
Update libcosmic #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-f0x
force-pushed
the
rebase
branch
2 times, most recently
from
b3b0275 to
07afd4b
Compare
git-f0x
force-pushed
the
rebase
branch
2 times, most recently
from
6cd36d1 to
b6772f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't work quite yet, because the greeter panics at theunimplemented!()lines ofview()functions.Not sure what should be done, since those weren't necessary previously. I tried putting a placeholder empty widget inside those functions, but it just results in a gray screen for the greeter, and a blank gray window on the desktop when logging in from a TTY.
Edit: This now doesn't panic (enabling multi-window fixed it), but the interface is transparent (the invisible buttons can be clicked and the popups show up), with just the Password text showing. Edit: actually, it seems the wallpaper is being displayed over the interface, since reducing its opacity makes the rest of the interface visible, but the buttons are still clickable and the password text is visible when the wallpaper covers the interface, so it's a bit strange.
The lock screen is also just a gray screen and non-functional.
But it does work to log in!