Support subpixel rendering #689
rust.yml
on: pull_request
cargo-deny
20s
build
3m 23s
Annotations
1 error and 41 warnings
build
Process completed with exit code 101.
|
cargo-deny
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
item in documentation is missing backticks:
src/shape_run_cache.rs#L36
warning: item in documentation is missing backticks
--> src/shape_run_cache.rs:36:61
|
36 | /// Remove anything in the cache with an age older than keep_ages
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
36 | /// Remove anything in the cache with an age older than `keep_ages`
| ~~~~~~~~~~~
|
manual saturating arithmetic:
src/shape.rs#L394
warning: manual saturating arithmetic
--> src/shape.rs:394:19
|
394 | let end = min(attrs_range.end, end_run)
| ___________________^
395 | | .checked_sub(start_run)
396 | | .unwrap_or(0);
| |_________________________^ help: consider using `saturating_sub`: `min(attrs_range.end, end_run).saturating_sub(start_run)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic
|
manual saturating arithmetic:
src/shape.rs#L391
warning: manual saturating arithmetic
--> src/shape.rs:391:21
|
391 | let start = max(attrs_range.start, start_run)
| _____________________^
392 | | .checked_sub(start_run)
393 | | .unwrap_or(0);
| |_________________________^ help: consider using `saturating_sub`: `max(attrs_range.start, start_run).saturating_sub(start_run)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic
= note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default
|
the borrowed expression implements the required traits:
src/line_ending.rs#L55
warning: the borrowed expression implements the required traits
--> src/line_ending.rs:55:49
|
55 | match self.string[start..self.end].find(&['\r', '\n']) {
| ^^^^^^^^^^^^^ help: change this to: `['\r', '\n']`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
item in documentation is missing backticks:
src/layout.rs#L61
warning: item in documentation is missing backticks
--> src/layout.rs:61:25
|
61 | /// Cache key, see [CacheKey]
| ^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
61 | /// Cache key, see [`CacheKey`]
| ~~~~~~~~~~
|
item in documentation is missing backticks:
src/layout.rs#L31
warning: item in documentation is missing backticks
--> src/layout.rs:31:17
|
31 | /// Unicode BiDi embedding level, character is left-to-right if `level` is divisible by 2
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
31 | /// Unicode `BiDi` embedding level, character is left-to-right if `level` is divisible by 2
| ~~~~~~
|
item in documentation is missing backticks:
src/font/system.rs#L112
warning: item in documentation is missing backticks
--> src/font/system.rs:112:27
|
112 | /// Buffer for use in FontFallbackIter.
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
112 | /// Buffer for use in `FontFallbackIter`.
| ~~~~~~~~~~~~~~~~~~
|
current MSRV (Minimum Supported Rust Version) is `1.65.0` but this item is stable since `1.66.0`:
src/font/fallback/mod.rs#L258
warning: current MSRV (Minimum Supported Rust Version) is `1.65.0` but this item is stable since `1.66.0`
--> src/font/fallback/mod.rs:258:86
|
258 | if let Some(fallback_info) = self.font_system.monospace_fallbacks_buffer.pop_first() {
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
|
current MSRV (Minimum Supported Rust Version) is `1.65.0` but this item is stable since `1.66.0`:
src/font/fallback/mod.rs#L149
warning: current MSRV (Minimum Supported Rust Version) is `1.65.0` but this item is stable since `1.66.0`
--> src/font/fallback/mod.rs:149:82
|
149 | if let Some(fallback_info) = self.font_system.monospace_fallbacks_buffer.pop_first() {
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: `#[warn(clippy::incompatible_msrv)]` on by default
|
item in documentation is missing backticks:
src/edit/mod.rs#L303
warning: item in documentation is missing backticks
--> src/edit/mod.rs:303:56
|
303 | /// Insert text at specified cursor with specified attrs_list
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
303 | /// Insert text at specified cursor with specified `attrs_list`
| ~~~~~~~~~~~~
|
consider adding a `;` to the last statement for consistent formatting:
src/edit/mod.rs#L200
warning: consider adding a `;` to the last statement for consistent formatting
--> src/edit/mod.rs:200:9
|
200 | self.with_buffer_mut(|buffer| buffer.set_redraw(redraw))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.with_buffer_mut(|buffer| buffer.set_redraw(redraw));`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
docs for function returning `Result` missing `# Errors` section:
src/edit/vi.rs#L1180
warning: docs for function returning `Result` missing `# Errors` section
--> src/edit/vi.rs:1180:5
|
1180 | / pub fn load_text<P: AsRef<std::path::Path>>(
1181 | | &mut self,
1182 | | path: P,
1183 | | attrs: crate::Attrs,
1184 | | ) -> std::io::Result<()> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
|
manual implementation of `Option::map`:
src/edit/vi.rs#L1141
warning: manual implementation of `Option::map`
--> src/edit/vi.rs:1141:37
|
1141 | / ... if let Some(last) = layout_runs.last() {
1142 | | ... Some(Action::Motion(Motion::GotoLine(
1143 | | ... (last.line_i + first.line_i) / 2,
1144 | | ... )))
1145 | | ... } else {
1146 | | ... None
1147 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
= note: `#[warn(clippy::manual_map)]` on by default
help: try
|
1141 ~ layout_runs.last().map(|last| Action::Motion(Motion::GotoLine(
1142 + (last.line_i + first.line_i) / 2,
1143 + )))
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
src/edit/vi.rs#L1014
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/edit/vi.rs:1014:37
|
1014 | / ... match text[..cursor.index]
1015 | | ... .char_indices()
1016 | | ... .filter_map(|(i, c)| {
1017 | | ... if c == find_c {
... |
1030 | | ... None => {}
1031 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
help: try
|
1014 ~ if let Some(i) = text[..cursor.index]
1015 + .char_indices()
1016 + .filter_map(|(i, c)| {
1017 + if c == find_c {
1018 + let end = i + c.len_utf8();
1019 + if end < cursor.index {
1020 + return Some(end);
1021 + }
1022 + }
1023 + None
1024 + })
1025 + .last() {
1026 + cursor.index = i;
1027 + }
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
src/edit/vi.rs#L994
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/edit/vi.rs:994:37
|
994 | / ... match text[..cursor.index]
995 | | ... .char_indices()
996 | | ... .filter(|&(_, c)| c == find_c)
997 | | ... .last()
... |
1002 | | ... None => {}
1003 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
help: try
|
994 ~ if let Some((i, _)) = text[..cursor.index]
995 + .char_indices()
996 + .filter(|&(_, c)| c == find_c)
997 + .last() {
998 + cursor.index = i;
999 + }
|
|
called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead:
src/edit/vi.rs#L888
warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead
--> src/edit/vi.rs:888:43
|
888 | ... match text[cursor.index..]
| _____________________________^
889 | | ... .char_indices()
890 | | ... .filter(|&(i, c)| i > 0 && c == find_c)
891 | | ... .next()
| |_________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
= note: `#[warn(clippy::filter_next)]` on by default
help: try
|
888 ~ match text[cursor.index..]
889 + .char_indices().find(|&(i, c)| i > 0 && c == find_c)
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
src/edit/vi.rs#L888
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/edit/vi.rs:888:37
|
888 | / ... match text[cursor.index..]
889 | | ... .char_indices()
890 | | ... .filter(|&(i, c)| i > 0 && c == find_c)
891 | | ... .next()
... |
896 | | ... None => {}
897 | | ... }
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
help: try
|
888 ~ if let Some((i, _)) = text[cursor.index..]
889 + .char_indices()
890 + .filter(|&(i, c)| i > 0 && c == find_c)
891 + .next() {
892 + cursor.index += i;
893 + }
|
|
match expression looks like `matches!` macro:
src/edit/vi.rs#L654
warning: match expression looks like `matches!` macro
--> src/edit/vi.rs:654:29
|
654 | let has_selection = match editor.selection() {
| _____________________________^
655 | | Selection::None => false,
656 | | _ => true,
657 | | };
| |_________^ help: try: `!matches!(editor.selection(), Selection::None)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
= note: `#[warn(clippy::match_like_matches_macro)]` on by default
|
docs for function returning `Result` missing `# Errors` section:
src/edit/vi.rs#L213
warning: docs for function returning `Result` missing `# Errors` section
--> src/edit/vi.rs:213:5
|
213 | / pub fn load_text<P: AsRef<std::path::Path>>(
214 | | &mut self,
215 | | font_system: &mut FontSystem,
216 | | path: P,
217 | | attrs: crate::Attrs,
218 | | ) -> std::io::Result<()> {
| |____________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
note: the lint level is defined here
--> src/lib.rs:86:9
|
86 | #![warn(clippy::missing_errors_doc)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
consider adding a `;` to the last statement for consistent formatting:
src/edit/syntect.rs#L128
warning: consider adding a `;` to the last statement for consistent formatting
--> src/edit/syntect.rs:128:13
|
128 | buffer.set_text(font_system, &text, attrs, Shaping::Advanced)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `buffer.set_text(font_system, &text, attrs, Shaping::Advanced);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
note: the lint level is defined here
--> src/lib.rs:90:9
|
90 | #![warn(clippy::semicolon_if_nothing_returned)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
src/edit/editor.rs#L533
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/edit/editor.rs:533:9
|
533 | / match self.change.take() {
534 | | Some(pending) => {
535 | | if !pending.items.is_empty() {
536 | | //TODO: is this a good idea?
... |
542 | | None => {}
543 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
533 ~ if let Some(pending) = self.change.take() {
534 + if !pending.items.is_empty() {
535 + //TODO: is this a good idea?
536 + log::warn!("pending change caused apply_change to be ignored!");
537 + self.change = Some(pending);
538 + return false;
539 + }
540 + }
|
|
this function has too many arguments (8/7):
src/edit/editor.rs#L112
warning: this function has too many arguments (8/7)
--> src/edit/editor.rs:112:5
|
112 | / pub fn draw<F>(
113 | | &self,
114 | | font_system: &mut FontSystem,
115 | | cache: &mut crate::SwashCache,
... |
120 | | mut f: F,
121 | | ) where
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
item in documentation is missing backticks:
src/cursor.rs#L92
warning: item in documentation is missing backticks
--> src/cursor.rs:92:63
|
92 | /// Move cursor to next character ([Self::Right] in LTR, [Self::Left] in RTL)
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
92 | /// Move cursor to next character ([Self::Right] in LTR, [`Self::Left`] in RTL)
| ~~~~~~~~~~~~
|
item in documentation is missing backticks:
src/cursor.rs#L92
warning: item in documentation is missing backticks
--> src/cursor.rs:92:41
|
92 | /// Move cursor to next character ([Self::Right] in LTR, [Self::Left] in RTL)
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
92 | /// Move cursor to next character ([`Self::Right`] in LTR, [Self::Left] in RTL)
| ~~~~~~~~~~~~~
|
item in documentation is missing backticks:
src/cursor.rs#L90
warning: item in documentation is missing backticks
--> src/cursor.rs:90:66
|
90 | /// Move cursor to previous character ([Self::Left] in LTR, [Self::Right] in RTL)
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
90 | /// Move cursor to previous character ([Self::Left] in LTR, [`Self::Right`] in RTL)
| ~~~~~~~~~~~~~
|
item in documentation is missing backticks:
src/cursor.rs#L90
warning: item in documentation is missing backticks
--> src/cursor.rs:90:45
|
90 | /// Move cursor to previous character ([Self::Left] in LTR, [Self::Right] in RTL)
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
help: try
|
90 | /// Move cursor to previous character ([`Self::Left`] in LTR, [Self::Right] in RTL)
| ~~~~~~~~~~~~
|
docs for function which may panic missing `# Panics` section:
src/cached.rs#L70
warning: docs for function which may panic missing `# Panics` section
--> src/cached.rs:70:5
|
70 | pub fn set_unused(&mut self) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/cached.rs:72:34
|
72 | *self = Self::Unused(self.take_used().expect("cached value should be used"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
docs for function which may panic missing `# Panics` section:
src/buffer_line.rs#L231
warning: docs for function which may panic missing `# Panics` section
--> src/buffer_line.rs:231:5
|
231 | / pub fn layout(
232 | | &mut self,
233 | | font_system: &mut FontSystem,
234 | | font_size: f32,
... |
238 | | tab_width: u16,
239 | | ) -> &[LayoutLine] {
| |______________________^
|
note: first possible panic found here
--> src/buffer_line.rs:258:9
|
258 | self.layout_opt.get().expect("layout not found")
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
docs for function which may panic missing `# Panics` section:
src/buffer_line.rs#L206
warning: docs for function which may panic missing `# Panics` section
--> src/buffer_line.rs:206:5
|
206 | pub fn shape(&mut self, font_system: &mut FontSystem, tab_width: u16) -> &ShapeLine {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/buffer_line.rs:222:9
|
222 | self.shape_opt.get().expect("shape not found")
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
usage of a legacy numeric method:
src/buffer.rs#L1160
warning: usage of a legacy numeric method
--> src/buffer.rs:1160:46
|
1160 | layout_cursor.glyph = usize::max_value();
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
1160 | layout_cursor.glyph = usize::MAX;
| ~~~
|
usage of a legacy numeric method:
src/buffer.rs#L1091
warning: usage of a legacy numeric method
--> src/buffer.rs:1091:51
|
1091 | layout_cursor.layout = usize::max_value();
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
help: use the associated constant instead
|
1091 | layout_cursor.layout = usize::MAX;
| ~~~
|
docs for function which may panic missing `# Panics` section:
src/buffer.rs#L399
warning: docs for function which may panic missing `# Panics` section
--> src/buffer.rs:399:5
|
399 | pub fn shape_until_scroll(&mut self, font_system: &mut FontSystem, prune: bool) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/buffer.rs:448:30
|
448 | let layout = self
| ______________________________^
449 | | .line_layout(font_system, line_i)
450 | | .expect("shape_until_scroll invalid line");
| |______________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
the loop variable `layout_i` is only used to index `layout`:
src/buffer.rs#L326
warning: the loop variable `layout_i` is only used to index `layout`
--> src/buffer.rs:326:29
|
326 | for layout_i in 0..layout_cursor.layout {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
|
326 | for <item> in layout.iter().take(layout_cursor.layout) {
| ~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
docs for function which may panic missing `# Panics` section:
src/buffer.rs#L308
warning: docs for function which may panic missing `# Panics` section
--> src/buffer.rs:308:5
|
308 | / pub fn shape_until_cursor(
309 | | &mut self,
310 | | font_system: &mut FontSystem,
311 | | cursor: Cursor,
312 | | prune: bool,
313 | | ) {
| |_____^
|
note: first possible panic found here
--> src/buffer.rs:317:29
|
317 | let layout_cursor = self
| _____________________________^
318 | | .layout_cursor(font_system, cursor)
319 | | .expect("shape_until_cursor invalid cursor");
| |________________________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
item in documentation is missing backticks:
src/buffer.rs#L205
warning: item in documentation is missing backticks
--> src/buffer.rs:205:10
|
205 | /// [BufferLine]s (or paragraphs) of text in the buffer
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
note: the lint level is defined here
--> src/lib.rs:84:9
|
84 | #![warn(clippy::doc_markdown)]
| ^^^^^^^^^^^^^^^^^^^^
help: try
|
205 | /// [`BufferLine`]s (or paragraphs) of text in the buffer
| ~~~~~~~~~~~~
|
docs for function which may panic missing `# Panics` section:
src/buffer.rs#L40
warning: docs for function which may panic missing `# Panics` section
--> src/buffer.rs:40:5
|
40 | pub fn highlight(&self, cursor_start: Cursor, cursor_end: Cursor) -> Option<(f32, f32)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/buffer.rs:62:25
|
62 | let x_end = x_end.expect("end of cursor not found");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
|
docs for function which may panic missing `# Panics` section:
src/attrs.rs#L343
warning: docs for function which may panic missing `# Panics` section
--> src/attrs.rs:343:5
|
343 | pub fn split_off(&mut self, index: usize) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: first possible panic found here
--> src/attrs.rs:359:34
|
359 | let (range, attrs) = self
| __________________________________^
360 | | .spans
361 | | .get_key_value(&key.start)
362 | | .map(|v| (v.0.clone(), v.1.clone()))
363 | | .expect("attrs span not found");
| |_______________________________________________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc
note: the lint level is defined here
--> src/lib.rs:88:9
|
88 | #![warn(clippy::missing_panics_doc)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
this `if` statement can be collapsed:
src/buffer.rs#L599
warning: this `if` statement can be collapsed
--> src/buffer.rs:599:17
|
599 | / if line.shape_opt().is_some() {
600 | | if line.text().contains('\t') {
601 | | line.reset_shaping();
602 | | }
603 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
599 ~ if line.shape_opt().is_some() && line.text().contains('\t') {
600 + line.reset_shaping();
601 + }
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|