warning: item in documentation is missing backticks --> src/edit/mod.rs:293:56 | 293 | /// Insert text at specified cursor with specified attrs_list | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown note: the lint level is defined here --> src/lib.rs:84:9 | 84 | #![warn(clippy::doc_markdown)] | ^^^^^^^^^^^^^^^^^^^^ help: try | 293 | /// Insert text at specified cursor with specified `attrs_list` | ~~~~~~~~~~~~

warning: consider adding a `;` to the last statement for consistent formatting --> src/edit/mod.rs:190:9 | 190 | self.with_buffer_mut(|buffer| buffer.set_redraw(redraw)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.with_buffer_mut(|buffer| buffer.set_redraw(redraw));` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

warning: docs for function returning `Result` missing `# Errors` section --> src/edit/vi.rs:1109:5 | 1109 | / pub fn load_text<P: AsRef<std::path::Path>>( 1110 | | &mut self, 1111 | | path: P, 1112 | | attrs: crate::Attrs, 1113 | | ) -> std::io::Result<()> { | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc

warning: manual implementation of `Option::map` --> src/edit/vi.rs:1074:37 | 1074 | / ... if let Some(last) = layout_runs.last() { 1075 | | ... Some(Action::Motion(Motion::GotoLine( 1076 | | ... (last.line_i + first.line_i) / 2, 1077 | | ... ))) 1078 | | ... } else { 1079 | | ... None 1080 | | ... } | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `#[warn(clippy::manual_map)]` on by default help: try | 1074 ~ layout_runs.last().map(|last| Action::Motion(Motion::GotoLine( 1075 + (last.line_i + first.line_i) / 2, 1076 + ))) |

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/edit/vi.rs:947:37 | 947 | / ... match text[..cursor.index] 948 | | ... .char_indices() 949 | | ... .filter_map(|(i, c)| { 950 | | ... if c == find_c { ... | 963 | | ... None => {} 964 | | ... } | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 947 ~ if let Some(i) = text[..cursor.index] 948 + .char_indices() 949 + .filter_map(|(i, c)| { 950 + if c == find_c { 951 + let end = i + c.len_utf8(); 952 + if end < cursor.index { 953 + return Some(end); 954 + } 955 + } 956 + None 957 + }) 958 + .last() { 959 + cursor.index = i; 960 + } |

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/edit/vi.rs:927:37 | 927 | / ... match text[..cursor.index] 928 | | ... .char_indices() 929 | | ... .filter(|&(_, c)| c == find_c) 930 | | ... .last() ... | 935 | | ... None => {} 936 | | ... } | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 927 ~ if let Some((i, _)) = text[..cursor.index] 928 + .char_indices() 929 + .filter(|&(_, c)| c == find_c) 930 + .last() { 931 + cursor.index = i; 932 + } |

warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead --> src/edit/vi.rs:821:43 | 821 | ... match text[cursor.index..] | _____________________________^ 822 | | ... .char_indices() 823 | | ... .filter(|&(i, c)| i > 0 && c == find_c) 824 | | ... .next() | |_________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next = note: `#[warn(clippy::filter_next)]` on by default help: try | 821 ~ match text[cursor.index..] 822 + .char_indices().find(|&(i, c)| i > 0 && c == find_c) |

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/edit/vi.rs:821:37 | 821 | / ... match text[cursor.index..] 822 | | ... .char_indices() 823 | | ... .filter(|&(i, c)| i > 0 && c == find_c) 824 | | ... .next() ... | 829 | | ... None => {} 830 | | ... } | |_______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 821 ~ if let Some((i, _)) = text[cursor.index..] 822 + .char_indices() 823 + .filter(|&(i, c)| i > 0 && c == find_c) 824 + .next() { 825 + cursor.index += i; 826 + } |

warning: match expression looks like `matches!` macro --> src/edit/vi.rs:597:29 | 597 | let has_selection = match editor.selection() { | _____________________________^ 598 | | Selection::None => false, 599 | | _ => true, 600 | | }; | |_________^ help: try: `!matches!(editor.selection(), Selection::None)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro = note: `#[warn(clippy::match_like_matches_macro)]` on by default

warning: docs for function returning `Result` missing `# Errors` section --> src/edit/vi.rs:192:5 | 192 | / pub fn load_text<P: AsRef<std::path::Path>>( 193 | | &mut self, 194 | | font_system: &mut FontSystem, 195 | | path: P, 196 | | attrs: crate::Attrs, 197 | | ) -> std::io::Result<()> { | |____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc note: the lint level is defined here --> src/lib.rs:86:9 | 86 | #![warn(clippy::missing_errors_doc)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: consider adding a `;` to the last statement for consistent formatting --> src/edit/syntect.rs:128:13 | 128 | buffer.set_text(font_system, &text, attrs, Shaping::Advanced) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `buffer.set_text(font_system, &text, attrs, Shaping::Advanced);` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned note: the lint level is defined here --> src/lib.rs:90:9 | 90 | #![warn(clippy::semicolon_if_nothing_returned)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/edit/editor.rs:489:9 | 489 | / match self.change.take() { 490 | | Some(pending) => { 491 | | if !pending.items.is_empty() { 492 | | //TODO: is this a good idea? ... | 498 | | None => {} 499 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 489 ~ if let Some(pending) = self.change.take() { 490 + if !pending.items.is_empty() { 491 + //TODO: is this a good idea? 492 + log::warn!("pending change caused apply_change to be ignored!"); 493 + self.change = Some(pending); 494 + return false; 495 + } 496 + } |

warning: docs for function which may panic missing `# Panics` section --> src/buffer_line.rs:198:5 | 198 | / pub fn layout_in_buffer( 199 | | &mut self, 200 | | scratch: &mut ShapeBuffer, 201 | | font_system: &mut FontSystem, ... | 204 | | wrap: Wrap, 205 | | ) -> &[LayoutLine] { | |______________________^ | note: first possible panic found here --> src/buffer_line.rs:213:9 | 213 | self.layout_opt.as_ref().expect("layout not found") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section --> src/buffer_line.rs:157:5 | 157 | / pub fn shape_in_buffer( 158 | | &mut self, 159 | | scratch: &mut ShapeBuffer, 160 | | font_system: &mut FontSystem, 161 | | ) -> &ShapeLine { | |___________________^ | note: first possible panic found here --> src/buffer_line.rs:172:9 | 172 | self.shape_opt.as_ref().expect("shape not found") | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section --> src/buffer.rs:375:5 | 375 | pub fn shape_until_scroll(&mut self, font_system: &mut FontSystem, prune: bool) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/buffer.rs:413:30 | 413 | let layout = self | ______________________________^ 414 | | .line_layout(font_system, line_i) 415 | | .expect("shape_until_scroll invalid line"); | |______________________________________________________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section --> src/buffer.rs:327:5 | 327 | / pub fn shape_until_cursor( 328 | | &mut self, 329 | | font_system: &mut FontSystem, 330 | | cursor: Cursor, 331 | | prune: bool, 332 | | ) { | |_____^ | note: first possible panic found here --> src/buffer.rs:335:29 | 335 | let layout_cursor = self | _____________________________^ 336 | | .layout_cursor(font_system, cursor) 337 | | .expect("shape_until_cursor invalid cursor"); | |________________________________________________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section --> src/buffer.rs:38:5 | 38 | pub fn highlight(&self, cursor_start: Cursor, cursor_end: Cursor) -> Option<(f32, f32)> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/buffer.rs:60:25 | 60 | let x_end = x_end.expect("end of cursor not found"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc

warning: docs for function which may panic missing `# Panics` section --> src/attrs.rs:285:5 | 285 | pub fn split_off(&mut self, index: usize) -> Self { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: first possible panic found here --> src/attrs.rs:301:34 | 301 | let (range, attrs) = self | __________________________________^ 302 | | .spans 303 | | .get_key_value(&key.start) 304 | | .map(|v| (v.0.clone(), v.1.clone())) 305 | | .expect("attrs span not found"); | |_______________________________________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc note: the lint level is defined here --> src/lib.rs:88:9 | 88 | #![warn(clippy::missing_panics_doc)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^