Use weight absolute difference in monospace fallback matching #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When matching on weights smaller than normal, "equal or smaller" weight restriction may cause monospace fallback to fail, depending on font support at such weights for the text to be shaped. So remove that restriction, and calculate weight differences instead of offsets. In case of no exact weight match, and with all other factors being equal, smaller weights will be picked before bigger ones. So, this should generally not cause any behavioral changes when matching on normal weight or bigger. Should fix pop-os/cosmic-term#104. Signed-off-by: Mohammad AlSaleh <[email protected]>
|
I can confirm that this do fix pop-os/cosmic-term#104 |
jackpot51
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When matching on weights smaller than normal, "equal or smaller"
weight restriction may cause monospace fallback to fail, depending
on font support at such weights for the text to be shaped.
So remove that restriction, and calculate weight differences instead
of offsets.
In case of no exact weight match, and with all other factors being
equal, smaller weights will be picked before bigger ones. So, this
should generally not cause any behavioral changes when matching on
normal weight or bigger.
Should fix pop-os/cosmic-term#104.