Fix: Undo and redo correctly updates editor modified status #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added an index that represents the last saved change. Editors are considered to be unsaved or modified if the current change is different from the save index. In other words, if the last saved change is `5`, undoing or redoing past that change should indicate that the editor has been modified. This is needed to fix two bugs in COSMIC Edit: * pop-os/cosmic-edit#116 * pop-os/cosmic-edit#128
I'll most likely simplify the API as end users don't have a way to cleanly use `Pivot::Exact` without access to the internal command buffer.
A unit test for an edge case currently fails but normal usage works.
jackpot51
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to two issues on cosmic-edit:
I implemented a fix for two
TODOs related to the issues above. Prior to this patch, undoing and redoing changes don't unset the editor's changed flag. The editor seems to be always marked as changed unless manually set to unchanged.I fixed this issue by adding a save point to the editor which sets the current change to the last saved state. Undoing or redoing past this change correctly sets the editor as modified. Undoing or redoing TO the save point sets the editor as unmodified.
I wrote several unit tests to validate the behavior above - they're likely clearer than my explanation above. 😹