Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the character index used for getting a glyph attribute in basic shaping #315

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

dekrain
Copy link
Contributor

@dekrain dekrain commented Sep 23, 2024

I am using glyphon, based on cosmic-text, to render text in my game, and using basic shaping for most buffers.
After updating, color variations in a buffer stopped working. I found out that a change in #202 was introduced that fetches the attribute data per glyph instead of per run, but it uses a wrong index (index of the code point inside the run instead of buffer text's position). I am unsure how that worked out in their scenario, my guess is that they only used spanned attributes at the beginning of buffers, but I fixed it now.

@jackpot51 jackpot51 merged commit 4fe90bb into pop-os:main Sep 23, 2024
@dekrain dekrain deleted the shaping_basic_fix_char_idx branch September 23, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants