Fix the character index used for getting a glyph attribute in basic shaping #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using glyphon, based on cosmic-text, to render text in my game, and using basic shaping for most buffers.
After updating, color variations in a buffer stopped working. I found out that a change in #202 was introduced that fetches the attribute data per glyph instead of per run, but it uses a wrong index (index of the code point inside the run instead of buffer text's position). I am unsure how that worked out in their scenario, my guess is that they only used spanned attributes at the beginning of buffers, but I fixed it now.