Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(en): Improve English consistency #112

Open
wants to merge 1 commit into
base: master_jammy
Choose a base branch
from

Conversation

atjn
Copy link
Contributor

@atjn atjn commented Jul 12, 2024

While fixing the Danish language, I noticed some inconsistencies in the English version. I have some suggestion to improve it.

@@ -3,13 +3,13 @@ action-applications-description = Pressing the Super key opens the Applications
action-launcher = Launcher
action-launcher-description = Pressing the Super key opens the Launcher
action-workspaces = Workspaces
action-workspaces-description = Pressing the Super key opens the Window and Workspaces Overview
action-workspaces-description = Pressing the Super key opens the Windows and Workspaces Overview
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make the name consistent with the same name on line 52.


click-action-cycle = Launch or Cycle Windows
click-action-minimize = Launch or Minimize Windows
click-action-minimize-or-previews = Launch, Minimize, or Preview Windows

date-combo = Date & Time and Notifications Position
date-combo = Calendar and Notifications Position
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is jarring to read "&" followed by "and". I suggest renaming "Date & Time" to "Calendar" to make this sentence much simpler.

Alternatively, it could be renamed to "Date, Time, and Notifications Position".

@@ -19,7 +19,7 @@ display-primary = Primary Display

dock-always-hide = Always hide
dock-always-hide-description = Dock always hides unless actively being revealed by the mouse
dock-always-visible = Always visible
dock-always-visible = Always show
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other two options describe an action (hide), but this option describes a passive state. It is mentally simpler if all three options describe an action.
Languages other than English can also construct sentences differently, depending on whether it is a state or action, and that can make the difference even more mentally challenging.

@@ -39,7 +39,7 @@ dock-size = Dock Size
dock-visibility = Dock Visibility
dock-workspaces = Show Workspaces Icon in Dock

gis-dock-description = Dock appearance, its size, and position can be changed at any time from the Settings application.
gis-dock-description = The Dock's appearance, size, and position can be changed at any time from the Settings application.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes the sentence simpler and easier to read.

@@ -49,10 +49,10 @@ gis-extensions-label1 = Manually installed GNOME Shell extensions are disabled t
gis-extensions-label2 = To this backup folder:
gis-extensions-title = GNOME Shell Extensions Update

gis-gestures-description = Use four finger swipe left to open Workspaces and windows overview, four fingers swipe right to open Applications, and four fingers swipe up or down to switch between workspaces. Swipe with three fingers to switch between windows.
gis-gestures-description = Use four finger swipe left to open the Windows and Workspaces Overview, four fingers swipe right to open Applications, and four fingers swipe up or down to switch between workspaces. Swipe with three fingers to switch between windows.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make the name consistent with the same name on line 6.

By adding "the", it makes it more clear that we are talking about a single named feature. Before, it could easily be misread as "open all the workspaces, then open the windows overview".

gis-gestures-title = Use Gestures for Easier Navigation

gis-launcher-description = Press Super key or use an icon in the dock to display the Launcher search field. Use arrow keys to quickly switch between open windows or type the name of the application to launch it. The Launcher makes navigating the desktop faster and more fluid.
gis-launcher-description = Press Super key or use an icon in the dock to display the Launcher search field. Use arrow keys to quickly switch between open windows or type the name of an application to launch it. The Launcher makes navigating the desktop faster and more fluid.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The application? What application are you specifically referring to?

position-right = Along the right side
position-bottom = Bottom
position-left = Left
position-right = Right
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the option for "bottom" uses a completely different sentence from the other two. In my opinion, there is no need to even be using sentences here, as it just makes it harder to read and understand the difference between the three options. By reducing each option to the only important word, it becomes much easier to read.


alignment-center = Center
alignment-center = Middle
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "center" is more commonly used together with "left" and "right". To me it makes the options more coherent when you use "middle".

@@ -93,11 +93,11 @@ top-bar = Top Bar

window-controls = Window Controls

workspace-picker-position = Placement of the Workspace Picker
workspace-picker-position = Position of the Workspace Picker
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only sentence that uses "placement" instead of "position". It makes more sense to use the same word everywhere.


workspaces-amount = Number of Workspaces
workspaces-dynamic = Dynamic Workspaces
workspaces-dynamic-description = Automatically removes empty workspaces.
workspaces-dynamic-description = Automatically removes empty workspaces
Copy link
Contributor Author

@atjn atjn Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other descriptions do not end with a period, only this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant