Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiling options #34

Open
wants to merge 2 commits into
base: master_hirsute
Choose a base branch
from
Open

Tiling options #34

wants to merge 2 commits into from

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Jul 12, 2021

Based on #32

@mmstick mmstick requested review from a team July 12, 2021 15:28
jackpot51
jackpot51 previously approved these changes Jul 12, 2021
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I change both the inner gaps and outer gaps options in the settings, the single "gaps" option in the top-right menu does not get updated:

Screenshot from 2021-07-12 11-15-30

If I change the option in the top-right menu, both the inner and outer options in Settings get updated. It seems like we need to consider whether the separate options should be shown in the top-right menu, or which option the top-right menu should show if they're set differently; as it is, the top-right option displays an incorrect value if one or both options are changed in Settings.

One other thing I noticed is that, while the other options are synced immediately between the top-right menu and Settings, they are not synced from Settings to the Extensions -> Pop Shell page until that page is closed and re-opened. (They do sync in the other direction from Extensions -> Pop Shell to Settings immediately.) That one seems like it might be a limitation of the Extensions app/preferences page system, and if that's the case, we should remove any settings being exposed in Settings from the experimental Extensions -> Pop Shell page after this is merged.

@jacobgkau
Copy link
Member

Also, should a .desktop file be added so this new page can be searched via the launcher?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants