-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add launch_3 and launch_heavy_3 #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta.json
files seem to be correct, other files match launch_1
/launch_2
and launch_heavy_1
as expected.
I've been meaning to de-duplicate things here so the same keymap.json
files could be shared by all QMK boards and all EC boards, and launch_1
/launch_2
/launch_3
could have the same files in keyboards
(which should also help with #139).
But this is right for how things currently work, assuming testing goes as expected.
@pop-os/quality-assurance any thoughts on this? |
Somehow I missed this, sorry about that. I'll look at it today. |
This will need to be updated slightly for the changes in #208. I can do that. |
Okay, rebased, added the
Edit: Or actually, do they match |
Updated system76/qmk_firmware#35 and this to use LED mapping that should be correct. |
I'm not sure if it's because of this PR or the firmware itself, but setting LEDs is not persistent across unplug/replugs. I can set the LEDs differently, but unplugging the keyboard and plugging it back in results in the default Spacetime LED pattern. Key binding changes still persist as expected, however. |
@leviport that would be firmware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the LED bug is due to firmware, I think this update is good to go. --launch-test
mode is working, keymap importing/exporting is working, and I can assign keys and LEDs on launch_3 and launch_heavy_3. Quick regression testing on launch_lite_1, launch_1, and my oryp9's bulit-in keyboard also went smoothly.
@ids1024 can you do an engineering review? |
I'm not sure if this has everything required, but it works to show these boards in the configurator. Please do a thorough review.