improv: Watch shortcut changes safely #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The unsafe code using |
|
Building from this branch, I don't seem to be seeing it show the keybinding change when I edit one in Gnome Control Center. |
|
Probably broke it on the last rebase |
mmstick
force-pushed
the
gsettings-improv_focal
branch
from
2f01614 to
9b5ad3f
Compare
|
Okay, it's working now. |
|
Unlike my previous implementation this doesn't seem to handle updates properly when the same gsettings key appears in two places (#34). |
|
Right, I'll fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.