fix(active-hint): bug fixes and feature max state hint #1014
Conversation
|
Not able to recreate #1013 (tested on 20.10 where it was reported.) Confirmed this fixes #990. Also confirmed the active hint now disappears on maximized windows when only one display is in use, but remains on maximized windows (but not fullscreened windows) when multiple displays are in use. I did discover a regression with half-snapped (Ctrl-Super-Left/Right) windows in non-tiling mode. The active hint is no longer visible on any edge except for the one in the middle of the screen (which isn't as helpful when two windows are open):
Compare this to the current behavior, which treats a half-tiled hint more like a maximized hint:
|
|
@jacobgkau - thanks for catching the new issue on snap left/right. I'll look into it later. |
|
@jacobgkau - snapping on edges should now be fixed |
|
I am seeing some issues when the gap is updated to 0. Will send additional changes in a while |
|
@jacobgkau - fixed regression on gaps = 0 |
|
I'm not sure this is actually an issue, but with the latest updates on this branch, half-snapping no longer works while tiling is enabled. This actually makes sense, but we may want to hide the half-snapping animation while tiling is enabled so it doesn't look like it's supposed to work. |
|
@jacobgkau - I found the issue on the snapping while tiled. I think removing the snap when tiled functionality is harder, because the light-blue overlay comes from gnome-shell and not on pop-shell. |
|
The snap when tiled, should be ready to test |
There was a problem hiding this comment.
Half-snapping is working as expected again. The hint improvements (maximize and out-of-screen) are still working as expected as well.
Regression testing passed:
shell-pr1014-hirsute.txt
shell-pr1014-focal.txt
Fixes #990
Fixes #1013
Implements #882 hide hint by checking monitor count if single on max state - there seems to be a consensus to still display hint on multi-monitor setup